Re: [PR] Re-anchor custom queued deadline references when a Dag run is cleared [airflow]

["seanghaeli (via GitHub)" <gi...@apache.org>]

seanghaeli commented on code in PR #71850:
URL: https://github.com/apache/airflow/pull/71850#discussion_r4067046707


##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -240,8 +245,13 @@ def _recalculate_dagrun_queued_at_deadlines(
         .where(
             Deadline.dagrun_id == dagrun.id,
             Deadline.missed == false(),
-            DeadlineAlertModel.reference[ReferenceModels.REFERENCE_TYPE_FIELD].as_string()
-            == ReferenceModels.DagRunQueuedAtDeadline.__name__,
+            or_(

Review Comment:
   We're not using the user defined deadline reference to compute the new deadline time, just using the default formula of `new_deadline_time = new_queued_at + deadline_interval`. I'm sure you recognized that already when writing this, as at the time of writing it isn't easily possible, but #70714 fixes exactly this limitation. That PR will be able to merge soon, in the meantime it would be great if you could re-base on that branch and implement computing the new deadline time according to the user's own Deadline Reference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org