You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "Adalennis (via GitHub)" <gi...@apache.org> on 2026/10/18 08:06:53 UTC
[PR] Reorganize the hop-conf page, fixes #4335 (hop)
Adalennis opened a new pull request, #9006:
URL: https://github.com/apache/hop/pull/9006
Fixes #4335
The hop-conf page started with a copy of the -h output and examples of how --project-variables is parsed, and didn't explain how to create a project.
- The page now starts with what hop-conf does, which file it changes and how to run it (hop-conf.sh, hop-conf.bat, hop conf).
- Projects: create, modify, list and delete, and project variables with the parsing examples in context.
- Environments: how they relate to a project, then create, add files from a directory, modify, list and delete. Outputs updated to the current ones.
- Configuration files: -cfg/-cfv/-cfd for environment files, -sv/-dv for the variables of hop-config.json.
- Options: the copy of the -h output is removed; the table at the end lists the options the page explains, from the current code (it had -azi, which no longer exists, old long names for -pla/-plm/-plt and a few typos). Azure gets -aze and Google Cloud -gcrbs.
- The shared snippet is included with leveloffset=+1, so projects/advanced.adoc also gets the project sections and the "section title out of sequence" warnings are gone.
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reorganize the hop-conf page, fixes #4335 (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer commented on PR #9006:
URL: https://github.com/apache/hop/pull/9006#issuecomment-6249537610
Thanks @Adalennis, this is a big improvement: the page now actually explains how to create a project. Docs-only, so nothing here can break anything.
**Fix before merge**
- **"Create a project" fails unless the home folder already exists** (`hop-conf-projects.adoc`, "Create a project"). `hop-conf.sh --project-create --project=sales --project-home=/data/projects/sales` stops with `Project 'sales' home folder '/data/projects/sales' does not exist`. Suggested fix: add `mkdir -p /data/projects/sales` to the example, or one line saying the home folder has to exist first.
**Worth fixing**
- **`-fj` / `--generate-fat-jar` was dropped from the Options table.** At least seven other pages (Beam, Flink, Spark, Databricks, lakehouse) tell readers to run `hop-conf.sh -fj` or `--generate-fat-jar`, and this page no longer mentions it. Suggested fix: add it back as a row (or as a short "Fat jar" line next to the cloud sections).
Verified: I ran every project, environment, config-file and `-sv`/`-dv` example on a current 2.20.0-SNAPSHOT client, with all five `--project-variables` quoting rows typed in bash. Apart from the item above, the outputs and the resulting JSON match the page. I also checked the Options table against the `@Option` definitions on `main`, and rendered both pages with Asciidoctor: the heading levels are right and there are no section-out-of-sequence warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reorganize the hop-conf page, fixes #4335 (hop)
Posted by "Adalennis (via GitHub)" <gi...@apache.org>.
Adalennis commented on PR #9006:
URL: https://github.com/apache/hop/pull/9006#issuecomment-6250145598
Thanks @bamaer. Both should be fixed now:
- Create a project: the example now creates the home folder first (mkdir -p), with a line saying it has to exist.
- -fj / --generate-fat-jar is back in the Options table, with -scv / --spark-client-version from the same plugin, in a "Beam and Spark" group that notes they need the Beam plugin. I'd missed them because the client I tested with didn't have the Beam engine installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reorganize the hop-conf page, fixes #4335 (hop)
Posted by "bamaer (via GitHub)" <gi...@apache.org>.
bamaer merged PR #9006:
URL: https://github.com/apache/hop/pull/9006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org