You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hiteshsai007 (via GitHub)" <gi...@apache.org> on 2026/06/25 07:36:25 UTC
[PR] [MNG-11449] Fix Mockito agent: use late binding @{} interpolation and extend to failsafe plugin [maven]
Hiteshsai007 opened a new pull request, #12369:
URL: https://github.com/apache/maven/pull/12369
The mockito profile activated by dependency:properties used Maven property interpolation (\) which resolves at POM parse time - before the dependency:properties goal runs and sets the org.mockito:mockito-core:jar property. This caused the javaagent path to remain unresolved.
Fix: use Surefire/Failsafe late-binding property interpolation (@{...}) which resolves the property at test execution time, after dependency:properties has already set it.
Also:
- Restore @{jacocoArgLine} placeholder (was dropped in previous attempt)
- Extend the profile to cover maven-failsafe-plugin as well
Fixes: https://issues.apache.org/jira/browse/MNG-11449
<!--
Please open pull requests against one of the following branches:
- master — default target for all changes (new features + bug fixes).
If the change should also go to maven-4.0.x, request a backport in the PR.
- maven-3.10.x — target for 3.x changes (new features + bug fixes).
If the change should also go to maven-3.9.x, request a backport in the PR.
maven-3.9.x should receive only serious bug fixes, as it is approaching EOL.
Backports are typically handled by maintainers;
however, after agreement you may open a separate backport PR to the target maintenance branch.
-->
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in other changes.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#11449] Fix Mockito agent: use late binding @{} interpolation and extend to failsafe plugin [maven]
Posted by "Hiteshsai007 (via GitHub)" <gi...@apache.org>.
Hiteshsai007 commented on PR #12369:
URL: https://github.com/apache/maven/pull/12369#issuecomment-4811528937
Thanks for the review! I've updated the PR to resolve the profile collision highlighted in the pre-existing note:
* **The Issue:** When both `jacoco` and `mockito` profiles were active, the `jacoco` profile's direct `surefire` plugin configuration overrode the `mockito` profile's `pluginManagement` configuration, dropping the Mockito `-javaagent`.
* **The Fix:** Refactored the `surefire` and `failsafe` `argLine` in `pom.xml` to be dynamically composed using properties:
- Added default `<argLine.xmx>-Xmx256m</argLine.xmx>` and `<argLine.mockito />` properties.
- Set the default plugin configuration to: `${argLine.xmx} @{jacocoArgLine} ${argLine.mockito}`.
- The `mockito` profile now only defines the `<argLine.mockito>` property.
- The `jacoco` profile now only overrides `<argLine.xmx>` to `-Xmx1G` (and no longer overrides the plugin's `argLine` configuration directly).
This ensures both profiles can be active at the same time without conflicting or dropping each other's parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#11449] Fix Mockito agent: use late binding @{} interpolation and extend to failsafe plugin [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #12369:
URL: https://github.com/apache/maven/pull/12369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org