You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Doug Sale (JIRA)" <ji...@apache.org> on 2008/07/17 15:09:31 UTC

[jira] Created: (LUCENENET-130) bug in unit test helper class Lucene.Net.Search.CheckHits

bug in unit test helper class Lucene.Net.Search.CheckHits
---------------------------------------------------------

                 Key: LUCENENET-130
                 URL: https://issues.apache.org/jira/browse/LUCENENET-130
             Project: Lucene.Net
          Issue Type: Bug
            Reporter: Doug Sale
            Priority: Minor


Attempts to compare 2 System.Collections.ArrayList instances via Assert.AreEquals(...)

C# Collections don't implement a reasonable Equals(Object o) method

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (LUCENENET-130) bug in unit test helper class Lucene.Net.Search.CheckHits

Posted by "George Aroush (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Aroush closed LUCENENET-130.
-----------------------------------


Applied patch and delivered.

> bug in unit test helper class Lucene.Net.Search.CheckHits
> ---------------------------------------------------------
>
>                 Key: LUCENENET-130
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-130
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Doug Sale
>            Priority: Minor
>         Attachments: CheckHits.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Attempts to compare 2 System.Collections.ArrayList instances via Assert.AreEquals(...)
> C# Collections don't implement a reasonable Equals(Object o) method

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (LUCENENET-130) bug in unit test helper class Lucene.Net.Search.CheckHits

Posted by "Doug Sale (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Sale resolved LUCENENET-130.
---------------------------------

    Resolution: Fixed

Fixed CheckHits bug:

System.Collections.ArrayList instances can't be judged equal by the Equals(Object o) method.  (I believe it checks to see if they are the same instance.)

The fix was to Assert that each ArrayList has an equal length, and if so then Assert that each element at the same position is equal.

Fixes the following unit test cases:

 Lucene.Net.Search.Spans.TestBasics.TestTerm
Lucene.Net.Search.Spans.TestBasics.TestTerm2
Lucene.Net.Search.Spans.TestBasics.TestPhrase
Lucene.Net.Search.Spans.TestBasics.TestPhrase2
Lucene.Net.Search.Spans.TestBasics.TestBoolean
Lucene.Net.Search.Spans.TestBasics.TestBoolean2
Lucene.Net.Search.Spans.TestBasics.TestSpanNearExact
Lucene.Net.Search.Spans.TestBasics.TestSpanNearUnordered
Lucene.Net.Search.Spans.TestBasics.TestSpanNearOrdered
Lucene.Net.Search.Spans.TestBasics.TestSpanNot
Lucene.Net.Search.Spans.TestBasics.TestSpanWithMultipleNotSingle
Lucene.Net.Search.Spans.TestBasics.TestSpanWithMultipleNotMany
Lucene.Net.Search.Spans.TestBasics.TestNpeInSpanNearWithSpanNot
Lucene.Net.Search.Spans.TestBasics.TestNpeInSpanNearInSpanFirstInSpanNot
Lucene.Net.Search.Spans.TestBasics.TestSpanFirst
Lucene.Net.Search.Spans.TestBasics.TestSpanOr
Lucene.Net.Search.Spans.TestBasics.TestSpanExactNested
Lucene.Net.Search.Spans.TestBasics.TestSpanNearOr
Lucene.Net.Search.Spans.TestBasics.TestSpanComplex1

Lucene.Net.Search.Spans.TestNearSpansOrdered.TestSpanNearQuery

Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrdered01
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual01
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual02
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual03
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual04
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual11
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual12
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual13
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual14
Lucene.Net.Search.Spans.TestSpans.TestSpanNearOrderedEqual15


> bug in unit test helper class Lucene.Net.Search.CheckHits
> ---------------------------------------------------------
>
>                 Key: LUCENENET-130
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-130
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Doug Sale
>            Priority: Minor
>         Attachments: CheckHits.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Attempts to compare 2 System.Collections.ArrayList instances via Assert.AreEquals(...)
> C# Collections don't implement a reasonable Equals(Object o) method

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LUCENENET-130) bug in unit test helper class Lucene.Net.Search.CheckHits

Posted by "Doug Sale (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENENET-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Sale updated LUCENENET-130:
--------------------------------

    Attachment: CheckHits.patch

fix for CheckHits.cs

> bug in unit test helper class Lucene.Net.Search.CheckHits
> ---------------------------------------------------------
>
>                 Key: LUCENENET-130
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-130
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Doug Sale
>            Priority: Minor
>         Attachments: CheckHits.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> Attempts to compare 2 System.Collections.ArrayList instances via Assert.AreEquals(...)
> C# Collections don't implement a reasonable Equals(Object o) method

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.