You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2003/09/19 23:46:47 UTC
Remove "temporary sanity checking" code from tweak_status
[[[
* subversion/libsvn_client/status.c
(tweak_status) Remove "temporary sanity checking" code.
]]]
Index: subversion/libsvn_client/status.c
===================================================================
--- subversion/libsvn_client/status.c (revision 7075)
+++ subversion/libsvn_client/status.c (working copy)
@@ -43,7 +43,6 @@
struct status_baton
{
- apr_hash_t *hash; /* ### temporary */
svn_boolean_t deleted_in_repos; /* target is deleted in repos */
svn_wc_status_func_t real_status_func; /* real status function */
void *real_status_baton; /* real status baton */
@@ -60,11 +59,6 @@
{
struct status_baton *sb = baton;
- /* ### temporary sanity checking code */
- assert (! apr_hash_get (sb->hash, path, APR_HASH_KEY_STRING));
- apr_hash_set (sb->hash, apr_pstrdup (apr_hash_pool_get (sb->hash), path),
- APR_HASH_KEY_STRING, (void *)1);
-
/* If we know that the target was deleted in HEAD of the repository,
we need to note that fact in all the status structures that come
through here. */
Can I remove this? At a guess it appears to have been checking for unintended recursion. If it needs to stay, please could someone provide a proper descriptive comment for it.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Remove "temporary sanity checking" code from tweak_status
Posted by Julian Foad <ju...@btopenworld.com>.
C.Michael Pilato wrote:
> Julian Foad <ju...@btopenworld.com> writes:
>
>>[[[
>>* subversion/libsvn_client/status.c
>> (tweak_status) Remove "temporary sanity checking" code.
>>]]]
>
> [...]
>
>>Can I remove this? At a guess it appears to have been checking for
>>unintended recursion. If it needs to stay, please could someone
>>provide a proper descriptive comment for it.
>
> Yep, that can go. I was using that because a nice, hard abort() is so
> much easier than trying to visually grep for duplicate status output
> lines.
Thanks. Gone in r7102.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Remove "temporary sanity checking" code from tweak_status
Posted by "C.Michael Pilato" <cm...@collab.net>.
Julian Foad <ju...@btopenworld.com> writes:
> [[[
> * subversion/libsvn_client/status.c
> (tweak_status) Remove "temporary sanity checking" code.
> ]]]
>
[...]
> Can I remove this? At a guess it appears to have been checking for
> unintended recursion. If it needs to stay, please could someone
> provide a proper descriptive comment for it.
Yep, that can go. I was using that because a nice, hard abort() is so
much easier than trying to visually grep for duplicate status output
lines.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org