You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/22 04:44:26 UTC
[GitHub] [kafka] d8tltanc opened a new pull request #8528: Changed the system tests for --zookeeper flag removal
d8tltanc opened a new pull request #8528:
URL: https://github.com/apache/kafka/pull/8528
* Remove the --zookeeper flags for node versions supporting --bootstrap-server for TopicCommand.
For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe commented on issue #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335
> For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet.
We need to keep using --zookeeper in the SCRAM case since we don't have an API for that yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc edited a comment on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc edited a comment on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-620311110
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3918/console
Link for the system tests ⬆️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc commented on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-620311110
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3917/console
Link for the system tests ⬆️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe closed pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe closed pull request #8528:
URL: https://github.com/apache/kafka/pull/8528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc edited a comment on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc edited a comment on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-628340161
Latest dev branch builds here (REMOVE_SYSTEM_4):
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3944/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc commented on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-628340161
Latest dev branch builds here (REMOVE_SYSTEM_4):
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3943/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-737387701
This was superseded by #9274 and some other changes. Closing for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-619440794
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe commented on issue #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343269
Same issue with `kafka-reassign-partitions.sh`. It also needs to be converted to use `--bootstrap-server`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe commented on issue #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-618343631
There are a lot of whitespace-only changes in this PR that are kind of confusing. Can you please do these in a separate PR or just drop them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe edited a comment on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe edited a comment on issue #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-618341335
> For the scram credential related code piece, switched to using --bootstrap-server even we don't support it yet.
We need to keep using --zookeeper in the SCRAM case since we don't have an API for that yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc commented on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-619341723
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc edited a comment on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc edited a comment on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-620311110
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3931/
Link for the system tests ⬆️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on issue #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
cmccabe commented on issue #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-618342661
It looks like the places where we invoke `kafka-configs.sh` still need to be converted over to use `--bootstrap-server`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] d8tltanc removed a comment on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions
Posted by GitBox <gi...@apache.org>.
d8tltanc removed a comment on pull request #8528:
URL: https://github.com/apache/kafka/pull/8528#issuecomment-620311110
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3931/
Link for the system tests ⬆️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org