You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/13 18:59:08 UTC
[GitHub] [geode] gesterzhou opened a new pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
gesterzhou opened a new pull request #6992:
URL: https://github.com/apache/geode/pull/6992
…arlier than provider
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
gesterzhou commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728333271
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
// let GII continue
P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
async3.join(MAX_WAIT * 2);
- count = getDeltaGIICount(P);
- assertEquals(0, count);
+ final int countConst = getDeltaGIICount(P);
+ GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));
Review comment:
You are right. I fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
gesterzhou commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728333271
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
// let GII continue
P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
async3.join(MAX_WAIT * 2);
- count = getDeltaGIICount(P);
- assertEquals(0, count);
+ final int countConst = getDeltaGIICount(P);
+ GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));
Review comment:
You are right. I fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jchen21 commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
jchen21 commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728316600
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
// let GII continue
P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
async3.join(MAX_WAIT * 2);
- count = getDeltaGIICount(P);
- assertEquals(0, count);
+ final int countConst = getDeltaGIICount(P);
+ GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));
Review comment:
Once `countConst` is assigned by `getDeltaGIICount(P)`, its value will not change. If its value is not `0`, no matter how long you wait, the assert in the next line still fails.
I was thinking about `GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, getDeltaGIICount(P)));`.
Please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728319849
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
// let GII continue
P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
async3.join(MAX_WAIT * 2);
- count = getDeltaGIICount(P);
- assertEquals(0, count);
+ final int countConst = getDeltaGIICount(P);
+ GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));
Review comment:
+1 to this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728319849
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
// let GII continue
P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
async3.join(MAX_WAIT * 2);
- count = getDeltaGIICount(P);
- assertEquals(0, count);
+ final int countConst = getDeltaGIICount(P);
+ GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));
Review comment:
+1 to this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou merged pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
gesterzhou merged pull request #6992:
URL: https://github.com/apache/geode/pull/6992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jchen21 commented on a change in pull request #6992: GEODE-9677: After provider sends ImageReply, requester could finish e…
Posted by GitBox <gi...@apache.org>.
jchen21 commented on a change in pull request #6992:
URL: https://github.com/apache/geode/pull/6992#discussion_r728316600
##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java
##########
@@ -1530,8 +1530,8 @@ public String description() {
// let GII continue
P.invoke(() -> resetGIITestHook(DuringPackingImage, true));
async3.join(MAX_WAIT * 2);
- count = getDeltaGIICount(P);
- assertEquals(0, count);
+ final int countConst = getDeltaGIICount(P);
+ GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, countConst));
Review comment:
Once `countConst` is assigned by `getDeltaGIICount(P)`, its value will not change. If its value is not `0`, no matter how long you wait, the assert in the next line still fails.
I was thinking about `GeodeAwaitility.await().untilAsserted(() -> assertEquals(0, getDeltaGIICount(P)));`.
Please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org