You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/09 14:49:36 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29997: Return error when group is not defined in breeze configuration
potiuk opened a new pull request, #29997:
URL: https://github.com/apache/airflow/pull/29997
When group was not found in Breeze configuration, we printed error but did not return error code - thus we missed the fact that some groups were not defined in breeze configuration.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29997: Return error when group is not defined in breeze configuration
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29997:
URL: https://github.com/apache/airflow/pull/29997#discussion_r1131219574
##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -508,7 +508,7 @@ def check_params(command: str, subcommand: str | None, command_dict: dict[str, A
f"defined in rich click configuration."
)
get_console().print(f"[warning]Please add it to the `{command_path_config(command)}`.")
- return False
+ return True
Review Comment:
`if errors_detected_in_params(` sounds better indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29997: Return error when group is not defined in breeze configuration
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29997:
URL: https://github.com/apache/airflow/pull/29997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #29997: Return error when group is not defined in breeze configuration
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #29997:
URL: https://github.com/apache/airflow/pull/29997#discussion_r1131158069
##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -508,7 +508,7 @@ def check_params(command: str, subcommand: str | None, command_dict: dict[str, A
f"defined in rich click configuration."
)
get_console().print(f"[warning]Please add it to the `{command_path_config(command)}`.")
- return False
+ return True
Review Comment:
It's kinda strange that for a function named `check_params` the return value of True means that something is wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29997: Return error when group is not defined in breeze configuration
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29997:
URL: https://github.com/apache/airflow/pull/29997#discussion_r1131189232
##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -508,7 +508,7 @@ def check_params(command: str, subcommand: str | None, command_dict: dict[str, A
f"defined in rich click configuration."
)
get_console().print(f"[warning]Please add it to the `{command_path_config(command)}`.")
- return False
+ return True
Review Comment:
Sure. Changed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org