You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/12/20 22:45:56 UTC

[GitHub] ctubbsii commented on a change in pull request #848: Remove unused declarations

ctubbsii commented on a change in pull request #848: Remove unused declarations
URL: https://github.com/apache/accumulo/pull/848#discussion_r243436599
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java
 ##########
 @@ -55,12 +54,8 @@
    *
    * @param key
    *          Key object of the entry you are collecting metrics from
-   *
-   * @param val
-   *          Value object of the entry you are collecting metrics from
-   *
    */
-  void addMetric(Key key, Value val);
 
 Review comment:
   Not sure about this one. Although not public API, the original intent was to make this flexible/pluggable. Another implementation could use it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services