You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/05/27 22:23:45 UTC
[GitHub] [camel-k] ammachado opened a new pull request, #3312: Detect wire tap EIP endpoints
ammachado opened a new pull request, #3312:
URL: https://github.com/apache/camel-k/pull/3312
<!-- Description -->
Detect dependencies used on wire tap EIP endpoints
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3312:
URL: https://github.com/apache/camel-k/pull/3312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#discussion_r885249758
##########
pkg/util/source/inspector_yaml.go:
##########
@@ -161,7 +161,7 @@ func (i YAMLInspector) parseStep(key string, content interface{}, meta *Metadata
switch key {
case "from":
meta.FromURIs = append(meta.FromURIs, maybeURI)
- case "to", "to-d", "toD":
+ case "to", "to-d", "toD", "wire-tap", "wireTap":
meta.ToURIs = append(meta.ToURIs, maybeURI)
Review Comment:
`meta.ToURIs` is reserved for the `to` DSL parameter
##########
pkg/util/source/inspector_yaml_test.go:
##########
@@ -125,6 +135,14 @@ func TestYAMLDependencies(t *testing.T) {
`mvn:org.apache.camel.k:camel-k-knative-consumer`,
},
},
+ {
+ name: "wireTap",
+ source: YAMLWiretapEIP,
+ dependencies: []string{
+ `mvn:org.apache.camel.k:camel-k-knative-producer`,
+ `mvn:org.apache.camel.k:camel-k-knative-consumer`,
Review Comment:
we're missing to check if the wiretap dependency component is present at this stage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#discussion_r886337740
##########
pkg/util/source/inspector_yaml_test.go:
##########
@@ -125,6 +135,14 @@ func TestYAMLDependencies(t *testing.T) {
`mvn:org.apache.camel.k:camel-k-knative-consumer`,
},
},
+ {
+ name: "wireTap",
+ source: YAMLWiretapEIP,
+ dependencies: []string{
+ `mvn:org.apache.camel.k:camel-k-knative-producer`,
+ `mvn:org.apache.camel.k:camel-k-knative-consumer`,
Review Comment:
Yeah, you're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] ammachado commented on a diff in pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
ammachado commented on code in PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#discussion_r885591343
##########
pkg/util/source/inspector_yaml.go:
##########
@@ -161,7 +161,7 @@ func (i YAMLInspector) parseStep(key string, content interface{}, meta *Metadata
switch key {
case "from":
meta.FromURIs = append(meta.FromURIs, maybeURI)
- case "to", "to-d", "toD":
+ case "to", "to-d", "toD", "wire-tap", "wireTap":
meta.ToURIs = append(meta.ToURIs, maybeURI)
Review Comment:
But that's not the case of wiretap? A special case of the "to" DSL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#issuecomment-1144570444
Thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] ammachado commented on pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
ammachado commented on PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#issuecomment-1141318149
I think now it also fixes #2139.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] ammachado commented on a diff in pull request #3312: Detect wire tap EIP endpoints
Posted by GitBox <gi...@apache.org>.
ammachado commented on code in PR #3312:
URL: https://github.com/apache/camel-k/pull/3312#discussion_r885600585
##########
pkg/util/source/inspector_yaml_test.go:
##########
@@ -125,6 +135,14 @@ func TestYAMLDependencies(t *testing.T) {
`mvn:org.apache.camel.k:camel-k-knative-consumer`,
},
},
+ {
+ name: "wireTap",
+ source: YAMLWiretapEIP,
+ dependencies: []string{
+ `mvn:org.apache.camel.k:camel-k-knative-producer`,
+ `mvn:org.apache.camel.k:camel-k-knative-consumer`,
Review Comment:
WireTap is a core component, it is not defined in a separate dependency, it is defined on the `camel-core-processor` dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org