You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ddanielr (via GitHub)" <gi...@apache.org> on 2023/04/20 20:16:42 UTC

[GitHub] [accumulo] ddanielr commented on pull request #3321: Add ProblemReport section to metadata schema

ddanielr commented on PR #3321:
URL: https://github.com/apache/accumulo/pull/3321#issuecomment-1516893266

   > I wonder if some of these APIs have a String equivalent, so we don't have to wrap them all with `new Text`. That could be another slight improvement that would go nicely along with this change (if they are equivalent).
   
   That's a great idea! I just added the changes to remove the Text wrappers. 
   Mutation already had a CharSequence method signature to use. I didn't think we needed to add a method for Strings, but happy to do so if that's desired. 
    
   I also had to modify the Encoding util to support a byte array for full removal of the Hadoop Text wrappers.
   
   This change seemed minimal as Encoding was only being used by ProblemReport and its test class and immediately generated a byte array from the Text object. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org