You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "je-enf (via GitHub)" <gi...@apache.org> on 2026/05/20 14:10:16 UTC

[I] The "Trigger again with this config" behavior can be misleading [airflow]

je-enf opened a new issue, #67243:
URL: https://github.com/apache/airflow/issues/67243

   ### Under which category would you file this issue?
   
   Airflow Core
   
   ### Apache Airflow version
   
   3.2.1
   
   ### What happened and how to reproduce it?
   
   Hello,
   
   Consider the following code minimal example:
   
   `from datetime import datetime, UTC
   
   from airflow.providers.standard.operators.python import PythonOperator
   from airflow import DAG
   from airflow.sdk import Param, get_current_context
   import logging
   
   
   def parse_params():
       ctx = get_current_context()
       logging.error(ctx["params"])
   
   
   with DAG(
       dag_id="test_params",
       start_date=datetime(2026, 1, 1, tzinfo=UTC),
       params={
           "my_param": Param(type="string", default="mystring"),
       },
       render_template_as_native_obj=True,
   ) as dag:
       trigger_batch = PythonOperator(
           task_id="parse_param",
           python_callable=parse_params,
       )
   `
   
   As this DAG contains a Param object, triggering it will always bring up the parameters UI.
   If I trigger it a first time with a given parameter for my_param, say 'foo', and then select that run, click "Trigger again with this config" and change 'foo' to 'bar', the value in the params dict of the context still contains 'foo'.
   
   ### What you think should happen instead?
   
   Either skip the parameters UI in that scenario or update the params with the new given values.
   
   ### Operating System
   
   debian
   
   ### Deployment
   
   None
   
   ### Apache Airflow Provider(s)
   
   _No response_
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Official Helm Chart version
   
   1.21.0 (latest released)
   
   ### Kubernetes Version
   
   _No response_
   
   ### Helm Chart configuration
   
   _No response_
   
   ### Docker Image customizations
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] The "Trigger again with this config" behavior can be misleading [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #67243:
URL: https://github.com/apache/airflow/issues/67243#issuecomment-4499247024

   Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] The "Trigger again with this config" behavior can be misleading [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 closed issue #67243: The "Trigger again with this config" behavior can be misleading
URL: https://github.com/apache/airflow/issues/67243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] The "Trigger again with this config" behavior can be misleading [airflow]

Posted by "arose26 (via GitHub)" <gi...@apache.org>.
arose26 commented on issue #67243:
URL: https://github.com/apache/airflow/issues/67243#issuecomment-5320046208

   This looks fixed on `main` and can probably be closed.
   
   `TriggerDAGForm.tsx` now tracks whether the prefill has been applied, and the effect that syncs the param store's `conf` back into the form field is gated on that rather than on the absence of a prefill:
   
   ```tsx
   useEffect(() => {
     if (conf && open && (!prefillConfig || hasAppliedPrefill)) {
       reset((prevValues) => ({ ...prevValues, conf }));
     }
   }, [conf, hasAppliedPrefill, prefillConfig, open, reset]);
   ```
   
   So the original conf is still restored when "Trigger again with this config" opens the form, and edits made afterwards in the Run Parameters UI now reach the submitted conf instead of being overwritten by the previous run's values.
   
   There is regression coverage for exactly this path in `TriggerDAGForm.test.tsx` — *"syncs Advanced Options JSON after Run Parameters edits in prefilled re-trigger mode"*. On current `main` the file's four tests pass for me.
   
   Worth a re-test against 3.3.0 by the reporter before closing, since the original report was on 3.2.1.
   
   ---
   Drafted-by: Claude Code (Opus 5) (no human review before posting)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org