You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/06/24 01:25:11 UTC

Review Request 22897: Add some relation operators to os::Release.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22897/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos-git


Description
-------

Used for upcoming review to compare to minimum required release for perf.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 0529f88c1f132aa58f027a97f769c132949207d7 

Diff: https://reviews.apache.org/r/22897/diff/


Testing
-------

none.


Thanks,

Ian Downes

Re: Review Request 22897: Add some relation operators to os::Release.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22897/#review46481
-----------------------------------------------------------

Ship it!


Please go ahead and commit.


3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/22897/#comment81864>

    How about this, seems a bit more straightforward:
    
    if (version != other.version) {
      return version < other.version;
    } else if (major != other.major) {
      return major < other.major;
    } else {
      return minor < other.minor;
    }



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/22897/#comment81865>

    Could we do it in the other order? < then == just like in the <= syntax? :)


- Ben Mahler


On June 23, 2014, 11:25 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22897/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 11:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Used for upcoming review to compare to minimum required release for perf.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 0529f88c1f132aa58f027a97f769c132949207d7 
> 
> Diff: https://reviews.apache.org/r/22897/diff/
> 
> 
> Testing
> -------
> 
> none.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 22897: Add some relation operators to os::Release.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22897/#review46613
-----------------------------------------------------------


Patch looks great!

Reviews applied: [22897]

All tests passed.

- Mesos ReviewBot


On June 24, 2014, 11:12 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22897/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 11:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Used for upcoming review to compare to minimum required release for perf.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 0529f88c1f132aa58f027a97f769c132949207d7 
> 
> Diff: https://reviews.apache.org/r/22897/diff/
> 
> 
> Testing
> -------
> 
> none.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 22897: Add some relation operators to os::Release.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22897/
-----------------------------------------------------------

(Updated June 24, 2014, 4:12 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Cleaned up. NNFR, will commit with dependent patch 22898.


Repository: mesos-git


Description
-------

Used for upcoming review to compare to minimum required release for perf.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 0529f88c1f132aa58f027a97f769c132949207d7 

Diff: https://reviews.apache.org/r/22897/diff/


Testing
-------

none.


Thanks,

Ian Downes

Re: Review Request 22897: Add some relation operators to os::Release.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22897/
-----------------------------------------------------------

(Updated June 24, 2014, 10:17 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

taking myself off this review. -- vinod


Repository: mesos-git


Description
-------

Used for upcoming review to compare to minimum required release for perf.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 0529f88c1f132aa58f027a97f769c132949207d7 

Diff: https://reviews.apache.org/r/22897/diff/


Testing
-------

none.


Thanks,

Ian Downes