You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/09/26 21:45:05 UTC

[GitHub] storm pull request #2348: [STORM-2757] Fix broken log links when HTTPS is in...

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2348

    [STORM-2757] Fix broken log links when HTTPS is in use

    jira: https://issues.apache.org/jira/browse/STORM-2757
    
    We have HTTPS configs for UI and Logviewer. But it's not working properly.  
    
    We should expect: 
    
    | UI        | LogViewer           | scheme of log links  | port of log links
    | ------------- |:-------------:| -----:|-----:|
    |HTTP | HTTP | http | logviewer.port
    |HTTP | HTTPS| https | logviewer.https.port
    |HTTPS | HTTPS| https|  logviewer.https.port
    |HTTPS | HTTP| should not work | should not work


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-2757

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2348
    
----
commit ab6abf9512403d809fe3babccb95686d462c614f
Author: Ethan Li <et...@gmail.com>
Date:   2017-09-26T15:17:55Z

    [STORM-2757] Fix broken log links when HTTPS is in use

----


---

[GitHub] storm pull request #2348: [STORM-2757] Fix broken log links when HTTPS is in...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2348


---

[GitHub] storm issue #2348: [STORM-2757] Fix broken log links when HTTPS is in use

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2348
  
    +1 Thanks for the fix.


---

[GitHub] storm issue #2348: [STORM-2757] Fix broken log links when HTTPS is in use

Posted by Ethanlm <gi...@git.apache.org>.

Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2348
  
    Tested it manually under all four combinations by visiting pages/links.
    
    | UI        | LogViewer           | all UI pages | Nimbus log | Supervisor log  | Worker log | Event Log | dumps and download | logviewer search | deap search 
    | ------------- |:-------------:| -----:|-----:|:-------------:| -----:|-----:|:-------------:| -----:|-----:|
    |HTTP | HTTP | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; |
    |HTTP | HTTPS|  &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; |
    |HTTPS | HTTPS|  &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; | &#10003; |
    |HTTPS | HTTP| x | x| x| x| x| x| x| x
    
    &#10003;  means working properly.  x means not working. 
    
    These are expected behaviors.
    
    



---