You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "László Bodor (Jira)" <ji...@apache.org> on 2020/01/21 13:31:00 UTC
[jira] [Comment Edited] (TEZ-4101) Eliminate some guava
dependencies by Java8+ features - Preconditions
[ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020232#comment-17020232 ]
László Bodor edited comment on TEZ-4101 at 1/21/20 1:30 PM:
------------------------------------------------------------
[~jeagles]: what do you think about this kind of separation of Preconditions? I feel the pain of handling guava versions in tez (+tez on hadoop), but at the same time I don't see the benefit of them...having multiple tez tickets which are blocked on guava (especially Preconditions), just because Precondition can throw a formatted exception if a boolean is evaluated to false...
maybe I can even "copy" the implementation instead of wrapping the calls to guava (it might be something similar what you did with Stopwatch in TEZ-3256)
without Preconditions, I see more chance to proceed with hadoop upgrades (e.g. TEZ-4100)
was (Author: abstractdog):
[~jeagles]: what do you think about this kind of separation of Preconditions? I feel the pain of handling guava versions in tez (+tez on hadoop), but at the same time I don't see the benefit of them...having multiple tez tickets which are blocked on guava (especially Preconditions), just because Precondition can throw a formatted exception if a boolean is evaluated to false...
maybe I can even "copy" the implementation instead of wrapping the calls to guava (it might be something similar what you did with Stopwatch in TEZ-3256)
> Eliminate some guava dependencies by Java8+ features - Preconditions
> --------------------------------------------------------------------
>
> Key: TEZ-4101
> URL: https://issues.apache.org/jira/browse/TEZ-4101
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Attachments: TEZ-4101.01.patch, TEZ-4101.02.patch
>
>
> 1. Preconditions.checkNotNull -> Objects.requireNonNull
> 2. wrap others into a tez common class
--
This message was sent by Atlassian Jira
(v8.3.4#803005)