You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/03 06:23:16 UTC

[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #37: [FLINK-26447] Clean up webhook jar and dependency management

gyfora commented on a change in pull request #37:
URL: https://github.com/apache/flink-kubernetes-operator/pull/37#discussion_r818348162



##########
File path: flink-kubernetes-webhook/pom.xml
##########
@@ -61,41 +62,4 @@ under the License.
         </dependency>
     </dependencies>
 
-    <build>
-        <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-shade-plugin</artifactId>

Review comment:
       I think we probably need to keep the shade plugin to include the netty classes in our jar. 
   
   But we can definitely remove the `flink-core` dependency and the exclusions for the `flink-kubernetes-operator`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org