You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/02/14 15:52:37 UTC

[GitHub] rgtk opened a new pull request #427: Fix beforeload for Android <= 7

rgtk opened a new pull request #427: Fix beforeload for Android <= 7
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/427
 
 
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   On Android <= 7, using `beforeload` would crash the application due to change of Android API.
   Fixes #386 
   
   
   
   ### Description
   If device is running Android <= 7, 
   
   ### Testing
   I ran it on Android 7 and 9, create `WebViewClient` instead of trying on relying on `WebView#getWebViewClient()` which is not available in these versions.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org