[jira] [Commented] (KYLIN-1615) UT 'HiveCmdBuilderTest' fail on 'testBeeline'

["Dong Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255265#comment-15255265 ] 

Dong Li commented on KYLIN-1615:
--------------------------------

Thanks Xianbin, patch is merged to master branch.
Do you mind also submit a patch for 1.3.x branch?

> UT 'HiveCmdBuilderTest' fail on 'testBeeline'
> ---------------------------------------------
>
>                 Key: KYLIN-1615
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1615
>             Project: Kylin
>          Issue Type: Bug
>          Components: Tools, Build and Test
>    Affects Versions: v1.5.2
>         Environment: windows 7
>            Reporter: wangxianbin
>            Assignee: hongbin ma
>            Priority: Minor
>         Attachments: 0001-KYLIN-1615-UT-HiveCmdBuilderTest-fail-on-testBeeline.patch
>
>
> this is  caused by line separator match fail.
> In 'testBeeline' the expected hqlStatement is hard code and the line separator is '\n', however, the line  separator of actual hqlStatement is generated by 'StringBuffer.newLine()' which uses the platform's own notion of line separator as defined by the system property <tt>line.separator</tt>. Not all platforms use the newline character ('\n') to terminate lines.
> error detail as follow:
> org.junit.ComparisonFailure:  <Click to see difference>
> 	at org.junit.Assert.assertEquals(Assert.java:115)
> 	at org.junit.Assert.assertEquals(Assert.java:144)
> 	at org.apache.kylin.source.hive.HiveCmdBuilderTest.testBeeline(HiveCmdBuilderTest.java:72)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)