[GitHub] [calcite] rubenada commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes

[GitBox <gi...@apache.org>]

rubenada commented on a change in pull request #1543: [CALCITE-3455] Redundant rule firing for both logical and physical nodes
URL: https://github.com/apache/calcite/pull/1543#discussion_r345628734
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java
 ##########
 @@ -60,7 +62,7 @@
    * {@link org.apache.calcite.rel.core.Correlate} from being de-correlated.
    */
   public static final FilterProjectTransposeRule INSTANCE =
-      new FilterProjectTransposeRule(Filter.class, Project.class, true, true,
+      new FilterProjectTransposeRule(LogicalFilter.class, LogicalProject.class, true, true,
 
 Review comment:
   Would it make sense (to keep backwards compatibility) to leave the rule's "default" `INSTANCE` as it is (matching Filter+Project), and create a separate e.g. `LOGICAL_INSTANCE` matching LogicalFilter+LogicalProject?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services