You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2012/08/16 21:28:43 UTC
svn commit: r1373999 - in
/tomcat/trunk/java/org/apache/coyote/http11/filters:
BufferedInputFilter.java ChunkedInputFilter.java ChunkedOutputFilter.java
FlushableGZIPOutputStream.java GzipOutputFilter.java IdentityInputFilter.java
Author: markt
Date: Thu Aug 16 19:28:42 2012
New Revision: 1373999
URL: http://svn.apache.org/viewvc?rev=1373999&view=rev
Log:
UCDectector
- Use of final
Modified:
tomcat/trunk/java/org/apache/coyote/http11/filters/BufferedInputFilter.java
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java
tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java
tomcat/trunk/java/org/apache/coyote/http11/filters/GzipOutputFilter.java
tomcat/trunk/java/org/apache/coyote/http11/filters/IdentityInputFilter.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/BufferedInputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/BufferedInputFilter.java?rev=1373999&r1=1373998&r2=1373999&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/BufferedInputFilter.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/BufferedInputFilter.java Thu Aug 16 19:28:42 2012
@@ -40,7 +40,7 @@ public class BufferedInputFilter impleme
// ----------------------------------------------------- Instance Variables
private ByteChunk buffered = null;
- private ByteChunk tempRead = new ByteChunk(1024);
+ private final ByteChunk tempRead = new ByteChunk(1024);
private InputBuffer buffer;
private boolean hasRead = false;
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java?rev=1373999&r1=1373998&r2=1373999&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java Thu Aug 16 19:28:42 2012
@@ -92,7 +92,7 @@ public class ChunkedInputFilter implemen
/**
* Byte chunk used to read bytes.
*/
- protected ByteChunk readChunk = new ByteChunk();
+ protected final ByteChunk readChunk = new ByteChunk();
/**
@@ -104,7 +104,7 @@ public class ChunkedInputFilter implemen
/**
* Byte chunk used to store trailing headers.
*/
- protected ByteChunk trailingHeaders = new ByteChunk();
+ protected final ByteChunk trailingHeaders = new ByteChunk();
/**
* Flag set to true if the next call to doRead() must parse a CRLF pair
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java?rev=1373999&r1=1373998&r2=1373999&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java Thu Aug 16 19:28:42 2012
@@ -57,7 +57,6 @@ public class ChunkedOutputFilter impleme
* Default constructor.
*/
public ChunkedOutputFilter() {
- chunkLength = new byte[10];
chunkLength[8] = (byte) '\r';
chunkLength[9] = (byte) '\n';
}
@@ -75,13 +74,13 @@ public class ChunkedOutputFilter impleme
/**
* Buffer used for chunk length conversion.
*/
- protected byte[] chunkLength = new byte[10];
+ protected final byte[] chunkLength = new byte[10];
/**
* Chunk header.
*/
- protected ByteChunk chunkHeader = new ByteChunk();
+ protected final ByteChunk chunkHeader = new ByteChunk();
// ------------------------------------------------------------- Properties
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java?rev=1373999&r1=1373998&r2=1373999&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java Thu Aug 16 19:28:42 2012
@@ -39,7 +39,7 @@ public class FlushableGZIPOutputStream e
* It is used to reserve one byte of real data so that it can be used when
* flushing the stream.
*/
- private byte[] lastByte = new byte[1];
+ private final byte[] lastByte = new byte[1];
private boolean hasLastByte = false;
@Override
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/GzipOutputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/GzipOutputFilter.java?rev=1373999&r1=1373998&r2=1373999&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/GzipOutputFilter.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/GzipOutputFilter.java Thu Aug 16 19:28:42 2012
@@ -37,7 +37,7 @@ public class GzipOutputFilter implements
/**
* Logger.
*/
- protected static org.apache.juli.logging.Log log =
+ protected static final org.apache.juli.logging.Log log =
org.apache.juli.logging.LogFactory.getLog(GzipOutputFilter.class);
@@ -59,7 +59,7 @@ public class GzipOutputFilter implements
/**
* Fake internal output stream.
*/
- protected OutputStream fakeOutputStream = new FakeOutputStream();
+ protected final OutputStream fakeOutputStream = new FakeOutputStream();
// --------------------------------------------------- OutputBuffer Methods
@@ -159,8 +159,8 @@ public class GzipOutputFilter implements
protected class FakeOutputStream
extends OutputStream {
- protected ByteChunk outputChunk = new ByteChunk();
- protected byte[] singleByteBuffer = new byte[1];
+ protected final ByteChunk outputChunk = new ByteChunk();
+ protected final byte[] singleByteBuffer = new byte[1];
@Override
public void write(int b)
throws IOException {
Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/IdentityInputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/IdentityInputFilter.java?rev=1373999&r1=1373998&r2=1373999&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/filters/IdentityInputFilter.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/IdentityInputFilter.java Thu Aug 16 19:28:42 2012
@@ -73,7 +73,7 @@ public class IdentityInputFilter impleme
/**
* Chunk used to read leftover bytes.
*/
- protected ByteChunk endChunk = new ByteChunk();
+ protected final ByteChunk endChunk = new ByteChunk();
// ------------------------------------------------------------- Properties
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org