You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/20 00:42:23 UTC

[jira] [Commented] (CB-10109) Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open

    [ https://issues.apache.org/jira/browse/CB-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429112#comment-15429112 ] 

ASF GitHub Bot commented on CB-10109:
-------------------------------------

Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
    Hi,
    Some issues I've encountered, pre-testing:
    
    1. Can you prefix the issue with CB-10109 so it can be automatically tracked by the apache bots to https://issues.apache.org/jira/browse/CB-10109
    2. All traces of "Ionic" have to be removed, in the docs or the code -- you'll have to rework the docs so that they are Cordova centric. All the contributors to this project (indeed any Apache project) are treated as if they are independent of any company and their contributions should reflect as such. Attribution is through the "Author" of the commit.
    3. jshint errors that need to be resolved:
    ```
    src/ios/xhr.js: line 55, col 8, Creating global 'for' variable. Should be 'for (var property ...'.
    src/ios/xhr.js: line 58, col 8, Creating global 'for' variable. Should be 'for (var property ...'.
    src/ios/xhr.js: line 55, col 8, 'property' is not defined.
    src/ios/xhr.js: line 56, col 20, 'property' is not defined.
    src/ios/xhr.js: line 58, col 8, 'property' is not defined.
    src/ios/xhr.js: line 59, col 9, 'property' is not defined.
    src/ios/xhr.js: line 59, col 64, 'property' is not defined.
    src/ios/xhr.js: line 60, col 16, 'property' is not defined.
    src/ios/xhr.js: line 60, col 40, 'property' is not defined.
    ```
    4. The contributor, in this case, @manucorporat, **must** file an [iCLA](https://www.apache.org/licenses/icla.txt) since this is a non-trivial contribution. This is required. I did not find one that was filed already.
    5. The contributor's employer, in this case @driftyco, should file a [CCLA](https://www.apache.org/licenses/cla-corporate.txt). Note that this is **not** required, but see this [FAQ item](http://www.apache.org/legal/resolved.html#are-contributors-required-to-sign-a-ccla) on why its a good idea (particularly for the committer).
    
    I'll proceed with reviewing the actual functionality of the code next week, unless there are any blockers to  issues 2, 4 and 5 that I have raised.


> Allow WKWebView to proxy file:// url loading in XmlHttpRequest.open
> -------------------------------------------------------------------
>
>                 Key: CB-10109
>                 URL: https://issues.apache.org/jira/browse/CB-10109
>             Project: Apache Cordova
>          Issue Type: Wish
>          Components: Plugin WKWebViewEngine
>            Reporter: Shazron Abdullah
>              Labels: wkwebview-known-issues
>
> Because of CORS, you can only open requests using http*:// schemes, not file.
> Ultimately this might be a new plugin. The plugin needs to:
> 1. Run a local webserver 
> 2. Proxy XmlHttpRequest.open and rewrite urls that go to (1) 
> The local webserver in (1) will route the requests using the appropriate handler, and will need to utilize a secret to prevent unauthorized access.
> Something like this: https://github.com/phonegap/connect-phonegap/blob/master/res/middleware/proxy.js



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org