You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/13 15:09:56 UTC

[GitHub] [hadoop] steveloughran opened a new pull request, #5218: HADOOP-18183. s3a audit logs to publish range start/end of GET requests.

steveloughran opened a new pull request, #5218:
URL: https://github.com/apache/hadoop/pull/5218

   The start and end of the range is set in a new audit param "rg", e.g "?rg=100-200"
   
   Contributed by Ankit Saurabh
   
   
   ### How was this patch tested?
   
   s3 london
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [X] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] steveloughran merged pull request #5218: HADOOP-18183. s3a audit logs to publish range start/end of GET requests.

Posted by GitBox <gi...@apache.org>.
steveloughran merged PR #5218:
URL: https://github.com/apache/hadoop/pull/5218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] steveloughran commented on pull request #5218: HADOOP-18183. s3a audit logs to publish range start/end of GET requests.

Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #5218:
URL: https://github.com/apache/hadoop/pull/5218#issuecomment-1351408553

   build was happy locally; test s3 london @ scale, and verified in logs that things worked
   ```
   183c9826b45486e485693808f38e2c4071004bf5dfd4c3ab210f0a21a4235ef8 stevel-london [14/Dec/2022:12:59:35 +0000] 109.157.193.147 arn:aws:iam::152813717728:user/stevel-dev 446CNGJCGD6DCZ4D REST.GET.OBJECT fork-0007/test/testReadSingleByteAcrossReadahead-sequential "GET /fork-0007/test/testReadSingleByteAcrossReadahead-sequential?versionId=uWXlWeVE5kCrTG.TRmC4gNekp5yWrELr HTTP/1.1" 206 - 2048 2048 28 14 "https://audit.example.org/hadoop/1/op_open/be0d9c4a-964e-423d-b22b-7fa5b56db268-00000029/?op=op_open&p1=fork-0007/test/testReadSingleByteAcrossReadahead-sequential&pr=stevel&ps=d12bd202-8831-4faf-965e-f3d7f23c3782&rg=0-2047&id=be0d9c4a-964e-423d-b22b-7fa5b56db268-00000029&t0=53&fs=be0d9c4a-964e-423d-b22b-7fa5b56db268&t1=53&ts=1671022775232" 
   
   here rg=0-2047; a single byte was read in a stream with sequential read and readahead.
   
   I am happy with this and doing the merge, as it is a yetus issue and have just done the testing locally.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] steveloughran commented on pull request #5218: HADOOP-18183. s3a audit logs to publish range start/end of GET requests.

Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #5218:
URL: https://github.com/apache/hadoop/pull/5218#issuecomment-1351503498

   merged, backporting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


[GitHub] [hadoop] steveloughran commented on pull request #5218: HADOOP-18183. s3a audit logs to publish range start/end of GET requests.

Posted by GitBox <gi...@apache.org>.
steveloughran commented on PR #5218:
URL: https://github.com/apache/hadoop/pull/5218#issuecomment-1348771609

   
   this is just #5110 with two changes
   * newline in logging message (checkstyle)
   * changed audit.md to say GET not GetObjectRequest
   
   if yetus is happy will merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org