[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9403: Add 16 metrics for TCP connections created for tunnels.

["ywkaras (via GitHub)" <gi...@apache.org>]

ywkaras commented on code in PR #9403:
URL: https://github.com/apache/trafficserver/pull/9403#discussion_r1105264077


##########
proxy/http/HttpSM.cc:
##########
@@ -5996,6 +5996,8 @@ HttpSM::do_setup_post_tunnel(HttpVC_t to_vc_type)
       tunnel.add_consumer(server_entry->vc, ua_entry->vc, &HttpSM::tunnel_handler_post_server, HT_HTTP_SERVER, "http server post");
     }
     server_entry->in_tunnel = true;
+    ink_assert(server_entry->vc != nullptr);
+    server_entry->vc->make_tunnel_endpoint();

Review Comment:
   `server_entry->vc` is a `VConnection` pointer, which is why `make_tunnel_endpoint()` has to be virtual member function of `VConnection`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org