You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2021/04/08 13:21:54 UTC

[GitHub] [karaf] grgrzybek opened a new pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

grgrzybek opened a new pull request #1343:
URL: https://github.com/apache/karaf/pull/1343


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] grgrzybek commented on pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

Posted by GitBox <gi...@apache.org>.
grgrzybek commented on pull request #1343:
URL: https://github.com/apache/karaf/pull/1343#issuecomment-815857994


   thanks! If it's fine, I'll backport to 4.2.x, ok?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on a change in pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #1343:
URL: https://github.com/apache/karaf/pull/1343#discussion_r609706165



##########
File path: management/server/src/main/java/org/apache/karaf/management/internal/Activator.java
##########
@@ -60,6 +60,8 @@
 
     private EventAdminLogger eventAdminLogger;
 
+    private String defaultRmiServerHostname;

Review comment:
       I would rather use a name like `originalRmiServerHostname` more than `default`. This field is more to store existing `java.rmi.server.hostname` (system property)  more than a default value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre merged pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1343:
URL: https://github.com/apache/karaf/pull/1343


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] grgrzybek commented on pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

Posted by GitBox <gi...@apache.org>.
grgrzybek commented on pull request #1343:
URL: https://github.com/apache/karaf/pull/1343#issuecomment-815829010


   works with 127.0.0.1, 0.0.0.0 and any IP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1343:
URL: https://github.com/apache/karaf/pull/1343#issuecomment-816416665


   Merged and cherry picked on `karaf-4.2.x` branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] grgrzybek commented on pull request #1343: [KARAF-7096] Ensure that RMIServerImpl_Stub contains correct rmiServerHost

Posted by GitBox <gi...@apache.org>.
grgrzybek commented on pull request #1343:
URL: https://github.com/apache/karaf/pull/1343#issuecomment-816421805


   Thanks for the backport!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org