[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4140: [CARBONDATA-4192] UT cases correction for validating the exception message correctly

[GitBox <gi...@apache.org>]

Indhumathi27 commented on a change in pull request #4140:
URL: https://github.com/apache/carbondata/pull/4140#discussion_r644496057



##########
File path: docs/addsegment-guide.md
##########
@@ -51,7 +51,7 @@ To support multiple formats per segment basis we can create multiple RDD using t
 Note: This integration will be clean as we use the sparks optimized reading, pruning and it

Review comment:
       ```suggestion
   **Note**: This integration will be clean as we use the sparks optimized reading, pruning and it
   ```

##########
File path: docs/addsegment-guide.md
##########
@@ -37,12 +37,12 @@ In the above command user can add the existing data to the carbon table as a new
 During add segment, it will infer the schema from data and validates the schema against the carbon table. 
 If the schema doesn’t match it throws an exception.
 
-###Changes to tablestatus file
+### Changes to tablestatus file

Review comment:
       Please change line 441 ‘format’  to `format`

##########
File path: docs/addsegment-guide.md
##########
@@ -17,14 +17,14 @@
 
 # Heterogeneous format segments in carbondata
 
-###Background
+### Background
 In the industry, many users already adopted to data with different formats like ORC, Parquet, JSON, CSV etc.,  
 If users want to migrate to Carbondata for better performance or for better features then there is no direct way. 
 All the existing data needs to be converted to Carbondata to migrate.  
 This solution works out if the existing data is less, what if the existing data is more?   
 Heterogeneous format segments aims to solve this problem by avoiding data conversion.
 
-###Add segment with path and format
+### Add segment with path and format
 Users can add the existing data as a segment to the carbon table provided the schema of the data
  and the carbon table should be the same. 
 

Review comment:
       Looks like syntax is wrong. Should be
   Alter table table_name add segment options (‘path’= 'hdfs://usr/oldtable,'format'='parquet')




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org