You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rp...@apache.org on 2014/09/20 16:36:45 UTC
git commit: bugfix in perf test: should specify
StringFormatMessageFactory when obtaining Logger
Repository: logging-log4j2
Updated Branches:
refs/heads/master 17e04f1ad -> c1abcc52c
bugfix in perf test: should specify StringFormatMessageFactory when
obtaining Logger
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/c1abcc52
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/c1abcc52
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/c1abcc52
Branch: refs/heads/master
Commit: c1abcc52c2adc98717253c1ccf1813bfb7f35c18
Parents: 17e04f1
Author: rpopma <rp...@apache.org>
Authored: Sat Sep 20 23:36:46 2014 +0900
Committer: rpopma <rp...@apache.org>
Committed: Sat Sep 20 23:36:46 2014 +0900
----------------------------------------------------------------------
.../log4j/perf/jmh/FormatterLoggerBenchmark.java | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/c1abcc52/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FormatterLoggerBenchmark.java
----------------------------------------------------------------------
diff --git a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FormatterLoggerBenchmark.java b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FormatterLoggerBenchmark.java
index 60c0bb7..1cbcb33 100644
--- a/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FormatterLoggerBenchmark.java
+++ b/log4j-perf/src/main/java/org/apache/logging/log4j/perf/jmh/FormatterLoggerBenchmark.java
@@ -23,6 +23,7 @@ import java.util.concurrent.TimeUnit;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.core.LifeCycle;
+import org.apache.logging.log4j.message.StringFormatterMessageFactory;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Level;
@@ -55,7 +56,7 @@ public class FormatterLoggerBenchmark {
new File("perftest.log").delete();
System.setProperty("log4j.configurationFile", "perf3PlainNoLoc.xml");
logger = LogManager.getLogger(getClass());
- formatterLogger = LogManager.getLogger("formatter");
+ formatterLogger = LogManager.getLogger("formatter", new StringFormatterMessageFactory());
}
@TearDown(Level.Trial)
@@ -74,28 +75,28 @@ public class FormatterLoggerBenchmark {
@Benchmark
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(TimeUnit.SECONDS)
- public void throughputLoggerString() {
+ public void throughputParameterizedString() {
logger.info("Message with {} parameter", "string");
}
@Benchmark
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(TimeUnit.SECONDS)
- public void throughputLoggerDouble() {
+ public void throughputParameterizedDouble() {
logger.info("Message with double param: {}", Math.PI);
}
@Benchmark
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(TimeUnit.SECONDS)
- public void throughputFormatterLoggerString() {
+ public void throughputStringFormatString() {
formatterLogger.info("Message with %s parameter", "string");
}
@Benchmark
@BenchmarkMode(Mode.Throughput)
@OutputTimeUnit(TimeUnit.SECONDS)
- public void throughputFormatterLoggerDouble() {
+ public void throughputStringFormatDouble() {
formatterLogger.info("Message with double param: %f", Math.PI);
}
@@ -109,28 +110,28 @@ public class FormatterLoggerBenchmark {
@Benchmark
@BenchmarkMode(Mode.SampleTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
- public void latencyLoggerString() {
+ public void latencyParameterizedString() {
logger.info("Message with {} parameter", "string");
}
@Benchmark
@BenchmarkMode(Mode.SampleTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
- public void latencyLoggerDouble() {
+ public void latencyParameterizedDouble() {
logger.info("Message with double param: {}", Math.PI);
}
@Benchmark
@BenchmarkMode(Mode.SampleTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
- public void latencyFormatterLoggerString() {
+ public void latencyStringFormatString() {
formatterLogger.info("Message with %s parameter", "string");
}
@Benchmark
@BenchmarkMode(Mode.SampleTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
- public void latencyFormatterLoggerDouble() {
+ public void latencyStringFormatDouble() {
formatterLogger.info("Message with double param: %f", Math.PI);
}
}