You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/03/22 14:57:27 UTC

[GitHub] activemq-artemis pull request #1969: ARTEMIS-1762 JdbcNodeManager shouldn't ...

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1969

    ARTEMIS-1762 JdbcNodeManager shouldn't be used if no HA is configured

    It forces to use InVMNodeManager when no HA option is selected with JDBC persistence and includes the checks that the only valid JDBC HA options are SHARED_STORE_MASTER and SHARED_STORE_SLAVE.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis no_jdbc_nm_no_ha

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1969
    
----
commit 17c138bf3d5d7784e3c5fb5709fcca15abc0d3a9
Author: Francesco Nigro <ni...@...>
Date:   2018-03-22T14:51:42Z

    ARTEMIS-1762 JdbcNodeManager shouldn't be used if no HA is configured
    
    It forces to use InVMNodeManager when no HA option is selected with JDBC persistence and includes the checks that the only valid JDBC HA options are SHARED_STORE_MASTER and SHARED_STORE_SLAVE.

----


---

[GitHub] activemq-artemis pull request #1969: ARTEMIS-1762 JdbcNodeManager shouldn't ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1969


---

[GitHub] activemq-artemis issue #1969: ARTEMIS-1762 JdbcNodeManager shouldn't be used...

Posted by andytaylor <gi...@git.apache.org>.

Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1969
  
    looks ok to me


---

[GitHub] activemq-artemis issue #1969: ARTEMIS-1762 JdbcNodeManager shouldn't be used...

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1969
  
    @andytaylor wdyt Re the checks on the HA policies? Seems safe enough?


---