You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/21 09:35:46 UTC

[GitHub] [incubator-mxnet] akarbown commented on pull request #19140: [BUGFIX] Fix for MKL symbol name clashing issue (#18855)

akarbown commented on pull request #19140:
URL: https://github.com/apache/incubator-mxnet/pull/19140#issuecomment-696006289


   > This option applies globally and affects all libraries statically linked into libmxnet.so. Thus the behavior should not depend on if MKL is disabled or enabled.
   > 
   > Also note that the option is not supported on Mac, so we may need to use a explicit symbol whitelist for consistency. #19057 has a similar change affecting only the distribution (think pypi) scripts.
   
   Hi @leezu 
   Thanks for the review!
   I see that you've done all the changes needed to avoid symbol clashing issue but for mxnet distribution version. I'd like to ask you whether it should be done for all the build types not only for distribution? So that all the developers would have it by default.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org