[GitHub] [incubator-dolphinscheduler] Baoqi opened a new pull request #1260: move batchDelete Process Define/Instance Outside for transactional

[GitBox <gi...@apache.org>]

Baoqi opened a new pull request #1260: move batchDelete Process Define/Instance Outside for transactional
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1260
 
 
   Currently, the  batchDeleteProcessDefinitionByIds  & batchDeleteProcessInstanceByIds  (batch operations) has Transaction problems.  
   
   they will make the inner function   deleteProcessDefinitionById  and  deleteProcessInstanceById  not transactional even if they are marked as so.   If those two deleteProcessDefinitionById  and  deleteProcessInstanceById  are  called inside batchDeleteProcessDefinitionByIds  & batchDeleteProcessInstanceByIds  .  so we need to move those batch operation out.
   
   
   You can refer to https://stackoverflow.com/questions/25738883/spring-transactional-annotation-when-using-try-catch-block
   ---------
   In proxy mode (which is the default), only external method calls coming in through the proxy are intercepted. This means that self-invocation, in effect, a method within the target object calling another method of the target object, will not lead to an actual transaction at runtime even if the invoked method is marked with @Transactional.
   ---------

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services