You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/17 19:55:10 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5651: Le fix 5.1.x
ocket8888 commented on a change in pull request #5651:
URL: https://github.com/apache/trafficcontrol/pull/5651#discussion_r596336428
##########
File path: traffic_ops/traffic_ops_golang/deliveryservice/letsencryptcert.go
##########
@@ -125,8 +125,8 @@ func (d *DNSProviderTrafficRouter) CleanUp(domain, token, keyAuth string) error
return errors.New("Determining rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error())
}
if rows == 0 {
- log.Errorf("Zero rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error())
- return errors.New("Zero rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error())
+ log.Errorf("Zero rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value)
Review comment:
If you're using Errorf anyway, why not use formatting parameters instead of string concatenation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org