You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/01/27 18:12:01 UTC

Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56028/
-----------------------------------------------------------

Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.


Bugs: MESOS-7021
    https://issues.apache.org/jira/browse/MESOS-7021


Repository: mesos


Description
-------

Consistently add the FollowSymlink stat argument on Windows.


Diffs
-----

  3rdparty/stout/include/stout/os/windows/stat.hpp e7f471b828d96bb5cd01823dd78c8570730712ea 

Diff: https://reviews.apache.org/r/56028/diff/


Testing
-------

make check (Fedora 25)


Thanks,

James Peach


Re: Review Request 56028: Consistently add the FollowSymlink stat argument on Windows.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56028/#review163314
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56027, 56028]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Jan. 27, 2017, 6:12 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56028/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 6:12 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7021
>     https://issues.apache.org/jira/browse/MESOS-7021
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consistently add the FollowSymlink stat argument on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/stat.hpp e7f471b828d96bb5cd01823dd78c8570730712ea 
> 
> Diff: https://reviews.apache.org/r/56028/diff/
> 
> 
> Testing
> -------
> 
> make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>