You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "tejaswini-imply (via GitHub)" <gi...@apache.org> on 2023/02/14 04:29:26 UTC
[GitHub] [druid] tejaswini-imply opened a new pull request, #13800: Fix MySQL drivers setup for Revised ITs
tejaswini-imply opened a new pull request, #13800:
URL: https://github.com/apache/druid/pull/13800
Existing revised ITs download both MariaDB and MySQL drivers during the docker image build phase and pack them with the docker image. But only the MySQL connector is added as a maven dependency during the test phase. This PR adds MariaDB connector as a dependency too and sets env var `MYSQL_DRIVER_CLASSNAME` (using `org.mariadb.jdbc.Driver` until decided to test with both drivers) as dynamic `druid.metadata.mysql.driver.driverClassName` config to be used by druid server and by tests while connecting to metadata store directly.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhagraw commented on pull request #13800: Fix MySQL drivers setup for Revised ITs
Posted by "abhagraw (via GitHub)" <gi...@apache.org>.
abhagraw commented on PR #13800:
URL: https://github.com/apache/druid/pull/13800#issuecomment-1429358107
I think, we should stick to the default here. Since druid uses mysql by default - we should be using org.mysql.jdbc.Driver until decided to test with both drivers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #13800: Fix MySQL drivers setup for Revised ITs
Posted by "abhishekagarwal87 (via GitHub)" <gi...@apache.org>.
abhishekagarwal87 merged PR #13800:
URL: https://github.com/apache/druid/pull/13800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org