You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/04 06:32:04 UTC
[GitHub] [incubator-superset] villebro commented on a change in pull request #10425: fix: db installation
villebro commented on a change in pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#discussion_r464828226
##########
File path: docs/installation.rst
##########
@@ -482,72 +482,67 @@ connect to the databases you want to access through Superset.
Here's a list of some of the recommended packages.
-+------------------+---------------------------------------+-------------------------------------------------+
-| database | pypi package | SQLAlchemy URI prefix |
-+==================+=======================================+=================================================+
-| Amazon Athena | ``pip install "PyAthenaJDBC>1.0.9"`` | ``awsathena+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Athena | ``pip install "PyAthena>1.2.0"`` | ``awsathena+rest://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Redshift | ``pip install sqlalchemy-redshift`` | ``redshift+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Drill | ``pip install sqlalchemy-drill`` | For the REST API:`` |
-| | | ``drill+sadrill://`` |
-| | | For JDBC |
-| | | ``drill+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Druid | ``pip install pydruid`` | ``druid://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Hive | ``pip install pyhive`` | ``hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Impala | ``pip install impyla`` | ``impala://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Kylin | ``pip install kylinpy`` | ``kylin://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Pinot | ``pip install pinotdb`` | ``pinot+http://CONTROLLER:5436/`` |
-| | | ``query?server=http://CONTROLLER:5983/`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Spark SQL | ``pip install pyhive`` | ``jdbc+hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| BigQuery | ``pip install pybigquery`` | ``bigquery://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| ClickHouse | ``pip install sqlalchemy-clickhouse`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| CockroachDB | ``pip install cockroachdb`` | ``cockroachdb://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Dremio | ``pip install sqlalchemy_dremio`` | ``dremio://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Elasticsearch | ``pip install elasticsearch-dbapi`` | ``elasticsearch+http://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Exasol | ``pip install sqlalchemy-exasol`` | ``exa+pyodbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Google Sheets | ``pip install gsheetsdb`` | ``gsheets://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| IBM Db2 | ``pip install ibm_db_sa`` | ``db2+ibm_db://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| MySQL | ``pip install mysqlclient`` | ``mysql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Oracle | ``pip install cx_Oracle`` | ``oracle://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| PostgreSQL | ``pip install psycopg2`` | ``postgresql+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Presto | ``pip install pyhive`` | ``presto://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Snowflake | ``pip install snowflake-sqlalchemy`` | ``snowflake://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQLite | | ``sqlite://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQL Server | ``pip install pymssql`` | ``mssql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Teradata | ``pip install sqlalchemy-teradata`` | ``teradata://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Vertica | ``pip install | ``vertica+vertica_python://`` |
-| | sqlalchemy-vertica-python`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Hana | ``pip install hdbcli sqlalchemy-hana``| ``hana://`` |
-| | or | |
-| | ``pip install apache-superset[hana]`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| database | pypi package | SQLAlchemy URI prefix |
++==================+===================================================================+=================================================+
+| Amazon Athena | ``pip install "apache-superset[athena]"`` | ``awsathena+jdbc://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Amazon Redshift | ``pip install "apache-superset[redshift]"`` | ``redshift+psycopg2://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Apache Drill | ``pip install "apache-superset[drill]"`` | For the REST API:`` |
+| | | ``drill+sadrill://`` |
+| | | For JDBC |
+| | | ``drill+jdbc://`` |
Review comment:
As long as drill doesn't have an `extras_require` we probably need to state here that there is no PyPI package for drill yet, and just link to the GitHub repo.
##########
File path: docs/installation.rst
##########
@@ -482,72 +482,67 @@ connect to the databases you want to access through Superset.
Here's a list of some of the recommended packages.
-+------------------+---------------------------------------+-------------------------------------------------+
-| database | pypi package | SQLAlchemy URI prefix |
-+==================+=======================================+=================================================+
-| Amazon Athena | ``pip install "PyAthenaJDBC>1.0.9"`` | ``awsathena+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Athena | ``pip install "PyAthena>1.2.0"`` | ``awsathena+rest://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Redshift | ``pip install sqlalchemy-redshift`` | ``redshift+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Drill | ``pip install sqlalchemy-drill`` | For the REST API:`` |
-| | | ``drill+sadrill://`` |
-| | | For JDBC |
-| | | ``drill+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Druid | ``pip install pydruid`` | ``druid://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Hive | ``pip install pyhive`` | ``hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Impala | ``pip install impyla`` | ``impala://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Kylin | ``pip install kylinpy`` | ``kylin://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Pinot | ``pip install pinotdb`` | ``pinot+http://CONTROLLER:5436/`` |
-| | | ``query?server=http://CONTROLLER:5983/`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Spark SQL | ``pip install pyhive`` | ``jdbc+hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| BigQuery | ``pip install pybigquery`` | ``bigquery://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| ClickHouse | ``pip install sqlalchemy-clickhouse`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| CockroachDB | ``pip install cockroachdb`` | ``cockroachdb://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Dremio | ``pip install sqlalchemy_dremio`` | ``dremio://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Elasticsearch | ``pip install elasticsearch-dbapi`` | ``elasticsearch+http://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Exasol | ``pip install sqlalchemy-exasol`` | ``exa+pyodbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Google Sheets | ``pip install gsheetsdb`` | ``gsheets://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| IBM Db2 | ``pip install ibm_db_sa`` | ``db2+ibm_db://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| MySQL | ``pip install mysqlclient`` | ``mysql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Oracle | ``pip install cx_Oracle`` | ``oracle://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| PostgreSQL | ``pip install psycopg2`` | ``postgresql+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Presto | ``pip install pyhive`` | ``presto://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Snowflake | ``pip install snowflake-sqlalchemy`` | ``snowflake://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQLite | | ``sqlite://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQL Server | ``pip install pymssql`` | ``mssql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Teradata | ``pip install sqlalchemy-teradata`` | ``teradata://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Vertica | ``pip install | ``vertica+vertica_python://`` |
-| | sqlalchemy-vertica-python`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Hana | ``pip install hdbcli sqlalchemy-hana``| ``hana://`` |
-| | or | |
-| | ``pip install apache-superset[hana]`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| database | pypi package | SQLAlchemy URI prefix |
Review comment:
Let's make the headers uniform:
```suggestion
| Database | PyPI package | SQLAlchemy URI prefix |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org