You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2015/12/08 19:22:10 UTC
[jira] [Commented] (FLINK-3147) HadoopOutputFormatBase should
expose mutexes for subclasses
[ https://issues.apache.org/jira/browse/FLINK-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047188#comment-15047188 ]
Chesnay Schepler commented on FLINK-3147:
-----------------------------------------
sounds like a good idea, and making the locks protected should solve this issue.
does anyone have any concerns over this?
> HadoopOutputFormatBase should expose mutexes for subclasses
> -----------------------------------------------------------
>
> Key: FLINK-3147
> URL: https://issues.apache.org/jira/browse/FLINK-3147
> Project: Flink
> Issue Type: Improvement
> Reporter: Nick Dimiduk
> Priority: Minor
>
> While adopting PhoenixOutputFormat to a streaming job, I find that the implementation of {{HadoopOutputFormatBase#close}} is not relevant when there's no temp file to move. However, subclasses cannot effectively override implementation because {{CLOSE_MUTEX}} is marked private.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)