You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/03/06 10:29:15 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5613: Display DB welcome only when no connections are defined.
sdedic opened a new pull request, #5613:
URL: https://github.com/apache/netbeans/pull/5613
The DB view initializes asynchronously, and in the meantime, before the "Connections" node's children are fetched (possibly empty!), the area shows the Welcome view.
In this PR a new decorating wrapper/callback is defined, that allows to process children returned from the NBLS. The DB view uses that to enable the welcome view only if the number of connections (children of the root node) is 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #5613: Display DB welcome only when no connections are defined.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #5613:
URL: https://github.com/apache/netbeans/pull/5613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jhorvath commented on a diff in pull request #5613: Display DB welcome only when no connections are defined.
Posted by "jhorvath (via GitHub)" <gi...@apache.org>.
jhorvath commented on code in PR #5613:
URL: https://github.com/apache/netbeans/pull/5613#discussion_r1126794798
##########
java/java.lsp.server/vscode/src/extension.ts:
##########
@@ -980,12 +980,20 @@ function doActivateWithJDK(specifiedJDK: string | null, context: ExtensionContex
class Decorator implements TreeItemDecorator<Visualizer> {
private provider : CustomizableTreeDataProvider<Visualizer>;
private setCommand : vscode.Disposable;
+ private initialized: boolean = false;
Review Comment:
Is this flag used anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists