You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/22 08:17:02 UTC

[GitHub] [flink] xuyangzhong opened a new pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

xuyangzhong opened a new pull request #17546:
URL: https://github.com/apache/flink/pull/17546


   ## What is the purpose of the change
   This pull request mainly helps give users clearer exception messages when the divisor is zero. Before, 1.0e0 / 0.0e0 will be computed to infinity and when converting it to decimal, an exception "Infinite or NaN" is thrown . Now we follow the SQL Standard: throw "Division by zero".
   
   ## Brief change log
   - add validate function in ExpressionReducer.
   - add a rule in ExpressionTestBase to fire the expression reducer.
   - change some existing test cases.
   - add some test cases to verify this change.
   
   ## Verifying this change
   - Some test cases have been added to verify this change.
   
   ## Does this pull request potentially affect one of the following parts:
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with @Public(Evolving): no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   - The S3 file system connector: no
   ## Documentation
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on a change in pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on a change in pull request #17546:
URL: https://github.com/apache/flink/pull/17546#discussion_r734333109



##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/SqlExpressionTest.scala
##########
@@ -124,8 +124,8 @@ class SqlExpressionTest extends ExpressionTestBase {
     testSqlApi("ROUND(-12.345, 2)", "-12.35")
     testSqlApi("PI()", "3.141592653589793")
     testSqlApi("E()", "2.718281828459045")
-    testSqlApi("truncate(42.345)", "42")
-    testSqlApi("truncate(cast(42.345 as decimal(5, 3)), 2)", "42.34")
+    testSqlApi("truncate(42.345)", "42.000")

Review comment:
       When the rule PROJECT_REDUCE_EXPRESSIONS is added into ExpressionTestBase, the bug [FLINK-23614] happens. And the bug is only fixed in 1.15. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "950452711",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "950452711",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] xuyangzhong commented on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-950452711


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398319


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 51ffb83f52f0334094f425d86aa5dd178a107267 (Fri Oct 22 08:21:22 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "triggerType" : "PUSH"
     }, {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "950452711",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363",
       "triggerID" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51ffb83f52f0334094f425d86aa5dd178a107267 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25363) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17546:
URL: https://github.com/apache/flink/pull/17546#issuecomment-949398959


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "51ffb83f52f0334094f425d86aa5dd178a107267",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 51ffb83f52f0334094f425d86aa5dd178a107267 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] godfreyhe closed pull request #17546: [FLINK-15987][tabel-planner-blink]SELECT 1.0e0 / 0.0e0 throws NumberFormatException

Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #17546:
URL: https://github.com/apache/flink/pull/17546


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org