You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2015/08/04 21:31:04 UTC
[jira] [Assigned] (WICKET-5960) Page header isn't rendered for
pages where URL has changed during render
[ https://issues.apache.org/jira/browse/WICKET-5960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier reassigned WICKET-5960:
----------------------------------
Assignee: Sven Meier
moving the code in #onDetach() to #onAfterRender() seems to fix the issue, I didn't notice any negative side effect
> Page header isn't rendered for pages where URL has changed during render
> ------------------------------------------------------------------------
>
> Key: WICKET-5960
> URL: https://issues.apache.org/jira/browse/WICKET-5960
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 7.0.0
> Reporter: Martijn Dashorst
> Assignee: Sven Meier
>
> Due to the changes in WICKET-5309, a page is re-rendered when any of the URL segments is modified during the request:
> From WebPageRenderer.java:
> {code}
> // the url might have changed after page has been rendered (e.g. the
> // stateless flag might have changed because stateful components
> // were added)
> final Url afterRenderUrl = requestCycle
> .mapUrlFor(getRenderPageRequestHandler());
> if (beforeRenderUrl.getSegments().equals(afterRenderUrl.getSegments()) == false)
> {
> // the amount of segments is different - generated relative URLs
> // will not work, we need to rerender the page. This can happen
> // with IRequestHandlers that produce different URLs with
> // different amount of segments for stateless and stateful pages
> response = renderPage(afterRenderUrl, requestCycle);
> }
> if (currentUrl.equals(afterRenderUrl))
> {code}
> The re-render causes the <head> section to be empty because it was already rendered in the first try.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)