[dev] [jira] [Commented] (LIBCLOUD-198) Enable libcloud to deploy to nodes with only private ip addresses

["Tomaz Muraus (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278583#comment-13278583 ] 

Tomaz Muraus commented on LIBCLOUD-198:
---------------------------------------

Thanks for your patch. I've committed it to trunk with some minor changes - http://svn.apache.org/viewvc?view=revision&revision=1339974:

- no need to use hasattr, just using getattr works fine, because it returns 'None' by default is the instance doesn't have the specified attribute
- expose ssh_interface argument in the deploy_node method
- throw an exception if ssh_interface not in ['public_ips', 'private_ips']
                
> Enable libcloud to deploy to nodes with only private ip addresses
> -----------------------------------------------------------------
>
>                 Key: LIBCLOUD-198
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-198
>             Project: Libcloud
>          Issue Type: New Feature
>          Components: Compute
>            Reporter: Jay Doane
>            Priority: Minor
>         Attachments: wait-until-running-ssh-interface.patch
>
>
> Some cloud providers (e.g. devstack) allow configurations that create nodes without public IP addresses.
> Unfortunately, libcloud only uses public IP addresses to test whether a node is running, and to subsequently connect via ssh to start a deployment.
> This patch exposes a new parameter called "ssh_interface" to the _wait_until_running() method, with a default value of "public_ips" to keep the existing behavior.  It also returns a tuple of the running node with the list of ip addresses that it actually waited for, which are then used by the ssh client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira