[GitHub] [cloudstack] ustcweizhou opened a new pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm

[GitBox <gi...@apache.org>]

ustcweizhou opened a new pull request #3965: server: Honor vm.destroy.forcestop when expunge a vm
URL: https://github.com/apache/cloudstack/pull/3965
 
 
   ## Description
   <!--- Describe your changes in detail -->
   
   When expunge a Running vm, vm will be stopped with forcestop=false which does not make sense. we should honor vm.destroy.forcestop in global setting, or always set forcestop=true.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] rhtyd commented on issue #3965: server: Honor vm.destroy.forcestop when expunge a vm

[GitBox <gi...@apache.org>]

rhtyd commented on issue #3965: server: Honor vm.destroy.forcestop when expunge a vm
URL: https://github.com/apache/cloudstack/pull/3965#issuecomment-599440888
 
 
   Usually we would expunged a destroyed VM which must be already stopped?
   LGTM nonetheless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] weizhouapache commented on issue #3965: server: Honor vm.destroy.forcestop when expunge a vm

[GitBox <gi...@apache.org>]

weizhouapache commented on issue #3965: server: Honor vm.destroy.forcestop when expunge a vm
URL: https://github.com/apache/cloudstack/pull/3965#issuecomment-599442985
 
 
   > Usually we would expunged a destroyed VM which must be already stopped?
   > LGTM nonetheless.
   
   actually there are two apis doing the same thing.
   
   ```
   expunge virtualmachine id=<vm id>
   destroy virtualmachine id=<vm id> expunge=True
   ```
   
   vm can be Running, Stopped, Destroyed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services