[GitHub] [druid] jihoonson commented on a change in pull request #10743: fix limited queries with subtotals

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #10743:
URL: https://github.com/apache/druid/pull/10743#discussion_r556259073



##########
File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferMinMaxOffsetHeap.java
##########
@@ -43,6 +43,7 @@
   private final LimitedBufferHashGrouper.BufferGrouperOffsetHeapIndexUpdater heapIndexUpdater;
 
   private int heapSize;
+  private int maxHeapSize;

Review comment:
       nit: this sounds like a max limit on the heap size while it is actually to remember the max value of heap size. Maybe some javadoc would help.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org