svn commit: r564786 - in /logging/log4j/branches/v1_2-branch/src: changes/changes.xml main/java/org/apache/log4j/HTMLLayout.java main/java/org/apache/log4j/xml/XMLLayout.java

[ca...@apache.org]

Author: carnold
Date: Fri Aug 10 15:20:44 2007
New Revision: 564786

URL: http://svn.apache.org/viewvc?view=rev&rev=564786
Log:
Bug 34874: Added notice to use UTF-8 or UTF-16 with HTML and XMLLayout's

Modified:
    logging/log4j/branches/v1_2-branch/src/changes/changes.xml
    logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/HTMLLayout.java
    logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/xml/XMLLayout.java

Modified: logging/log4j/branches/v1_2-branch/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4j/branches/v1_2-branch/src/changes/changes.xml?view=diff&rev=564786&r1=564785&r2=564786
==============================================================================
--- logging/log4j/branches/v1_2-branch/src/changes/changes.xml (original)
+++ logging/log4j/branches/v1_2-branch/src/changes/changes.xml Fri Aug 10 15:20:44 2007
@@ -22,6 +22,7 @@
   <body>
   
     <release version="1.2.15" date="2007-06-27" description="SyslogAppender enhancements, NTEventLogAppender and Maven build.">
+       <action action="fix" issue="34874">Notice to use UTF-8 or UTF-16 encoding added to XML and HTMLLayout javadoc.</action>
        <action action="fix" issue="34875">XML and HTMLLayout do not always escape special characters.</action>
        <action action="add" issue="43078">Optionally render MDC content in XMLLayout</action>
        <action action="fix" issue="42694">Typo in log4j.dtd concerning threshold.</action>

Modified: logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/HTMLLayout.java
URL: http://svn.apache.org/viewvc/logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/HTMLLayout.java?view=diff&rev=564786&r1=564785&r2=564786
==============================================================================
--- logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/HTMLLayout.java (original)
+++ logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/HTMLLayout.java Fri Aug 10 15:20:44 2007
@@ -22,9 +22,14 @@
 import org.apache.log4j.helpers.Transform;
 
 /**
-   This layout outputs events in a HTML table.
-
-   @author Ceki G&uuml;lc&uuml;
+ * This layout outputs events in a HTML table.
+ *
+ * Appenders using this layout should have their encoding
+ * set to UTF-8 or UTF-16, otherwise events containing
+ * non ASCII characters could result in corrupted
+ * log files.
+ *
+ *  @author Ceki G&uuml;lc&uuml;
  */
 public class HTMLLayout extends Layout {
 

Modified: logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/xml/XMLLayout.java
URL: http://svn.apache.org/viewvc/logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/xml/XMLLayout.java?view=diff&rev=564786&r1=564785&r2=564786
==============================================================================
--- logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/xml/XMLLayout.java (original)
+++ logging/log4j/branches/v1_2-branch/src/main/java/org/apache/log4j/xml/XMLLayout.java Fri Aug 10 15:20:44 2007
@@ -57,6 +57,11 @@
  * prior to log4j 1.2 (final release) and "1.2" for relase 1.2 and
  * later.
  *
+ * Appenders using this layout should have their encoding
+ * set to UTF-8 or UTF-16, otherwise events containing
+ * non ASCII characters could result in corrupted
+ * log files. 
+ *
  * @author Ceki  G&uuml;lc&uuml;
  * @since 0.9.0 
  * */



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org