You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2015/07/24 16:01:04 UTC

[jira] [Resolved] (LUCENE-6696) FilterDirectoryReader.doClose() should call in.close() not in.doClose()

     [ https://issues.apache.org/jira/browse/LUCENE-6696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrien Grand resolved LUCENE-6696.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 5.3

> FilterDirectoryReader.doClose() should call in.close() not in.doClose()
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-6696
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6696
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 5.3
>
>         Attachments: LUCENE-6696.patch
>
>
> FilterDirectoryReader.doClose() calls in.doClose(). This is wrong because if you call close() on both the underlying reader and a wrapper around it, then doClose() will have been called several times, which will break ref counting.
> Instead, FilterDirectoryReader.doClose() should call in.close() so that it is a no-op if the underlying reader is already closed, or so that calling close() on the underlying reader afterwards will be a no-op.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org