[jira] [Commented] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219452#comment-16219452 ] 

ASF GitHub Bot commented on THRIFT-4373:
----------------------------------------

GitHub user sokac opened a pull request:

    https://github.com/apache/thrift/pull/1401

    THRIFT-4373: Derefer PHP zval _TSPEC

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sokac/thrift php

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1401
    
----
commit d6d493d0f0dcae2f892fe0f5ed99884689069e13
Author: Josip Sokcevic <js...@thumbtack.com>
Date:   2017-10-25T16:45:16Z

    THRIFT-4373: Derefer PHP zval _TSPEC

----


> Extending Thrift class results in "Attempt serialize from non-Thrift object"
> ----------------------------------------------------------------------------
>
>                 Key: THRIFT-4373
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4373
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.10.0
>         Environment: Linux 4.13.3-1-ARCH
> PHP 7.1.10
>            Reporter: Josip Sokcevic
>         Attachments: 0001-THRIFT-4373-Derefer-PHP-zval-_TSPEC.patch
>
>
> This happens when using php extension. thrift_protocol_write_binary will check Z_TYPE_P of spec and expects to be array (IS_ARRAY). However, PHP7 will set it as reference (IS_REFERENCE).
> Example:
> {code}
> $s = new Serializer\TBinarySerializer();
> // Foo is a Thrift type class
> class FooExtended extends Foo {}
> $o = new Foo();
> $o2 = new FooExtended();
> // this works just fine:
> $s->serialize($o); // this uses thrift_protocol_write_binary if available
> // Next line throws \Thrift\Exception\TProtocolException if thrift_protocol_write_binary is used
> // However, it doesn't break if no extension is available.
> $s->serialize($o);
> {code}
> Proposed solution is to dereference using ZVAL_DEREF before checking types (attached). Alternative would be to mark struct type classes as final, but that break compatibility.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)