You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by trejkaz <gi...@git.apache.org> on 2013/05/21 04:36:29 UTC

poi pull request: HSSFWorkbook.getAllEmbeddedObjects wasn't getting all emb...

GitHub user trejkaz opened a pull request:

    https://github.com/apache/poi/pull/2

    HSSFWorkbook.getAllEmbeddedObjects wasn't getting all embedded objects

    HSSFWorkbook.getAllEmbeddedObjects wasn't getting all embedded objects, only the top-level ones. This fixes it to get them recursively.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trejkaz/poi patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/poi/pull/2.patch

----
commit 5ee3a2d1d0661fb0cf071e2f824d36ed29b8b899
Author: Trejkaz (pen name) <tr...@trypticon.org>
Date:   2013-05-21T02:35:58Z

    Update HSSFWorkbook.java
    
    HSSFWorkbook.getAllEmbeddedObjects wasn't getting all embedded objects, only the top-level ones.

----


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Re: poi pull request: HSSFWorkbook.getAllEmbeddedObjects wasn't getting all emb...

Posted by Dave Fisher <wa...@apache.org>.
Poi is an svn project as you should already know.

Sent from my iPhone

On May 20, 2013, at 7:36 PM, trejkaz <gi...@git.apache.org> wrote:

> GitHub user trejkaz opened a pull request:
> 
>    https://github.com/apache/poi/pull/2
> 
>    HSSFWorkbook.getAllEmbeddedObjects wasn't getting all embedded objects
> 
>    HSSFWorkbook.getAllEmbeddedObjects wasn't getting all embedded objects, only the top-level ones. This fixes it to get them recursively.
> 
> You can merge this pull request into a Git repository by running:
> 
>    $ git pull https://github.com/trejkaz/poi patch-1
> 
> Alternatively you can review and apply these changes as the patch at:
> 
>    https://github.com/apache/poi/pull/2.patch
> 
> ----
> commit 5ee3a2d1d0661fb0cf071e2f824d36ed29b8b899
> Author: Trejkaz (pen name) <tr...@trypticon.org>
> Date:   2013-05-21T02:35:58Z
> 
>    Update HSSFWorkbook.java
> 
>    HSSFWorkbook.getAllEmbeddedObjects wasn't getting all embedded objects, only the top-level ones.
> 
> ----
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org