You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/17 15:52:57 UTC
Review Request 41515: Refactored error messages to reduce jaggedness.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Includes minor updates to wording and punctuation.
Diffs
-----
src/master/quota_handler.cpp 11167879b2480d9c8dd6398ca39c479089ec2272
Diff: https://reviews.apache.org/r/41515/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41515: Refactored error messages to reduce
jaggedness.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/#review111094
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41514, 41515]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 17, 2015, 2:52 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41515/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Includes minor updates to wording and punctuation.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 11167879b2480d9c8dd6398ca39c479089ec2272
>
> Diff: https://reviews.apache.org/r/41515/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41515: Refactored error messages to reduce
jaggedness.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/#review111036
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Dec. 17, 2015, 2:52 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41515/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Includes minor updates to wording and punctuation.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 11167879b2480d9c8dd6398ca39c479089ec2272
>
> Diff: https://reviews.apache.org/r/41515/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41515: Refactored error messages to reduce
jaggedness.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/#review111640
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 22, 2015, 6:08 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41515/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 6:08 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
>
>
> Bugs: MESOS-3960
> https://issues.apache.org/jira/browse/MESOS-3960
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Includes minor updates to wording and punctuation.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
>
> Diff: https://reviews.apache.org/r/41515/diff/
>
>
> Testing
> -------
>
> make check on Mac OS 10.10.4
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 41515: Refactored error messages to reduce
jaggedness.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 6:08 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
Changes
-------
Rebased.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Includes minor updates to wording and punctuation.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/41515/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41515: Refactored error messages to reduce
jaggedness.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/
-----------------------------------------------------------
(Updated Dec. 22, 2015, 11:02 a.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
Changes
-------
Rebased.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Includes minor updates to wording and punctuation.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/41515/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov
Re: Review Request 41515: Refactored error messages to reduce
jaggedness.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41515/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 1:30 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Neil Conway.
Changes
-------
Rebased.
Bugs: MESOS-3960
https://issues.apache.org/jira/browse/MESOS-3960
Repository: mesos
Description
-------
Includes minor updates to wording and punctuation.
Diffs (updated)
-----
src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10
Diff: https://reviews.apache.org/r/41515/diff/
Testing
-------
make check on Mac OS 10.10.4
Thanks,
Alexander Rukletsov