You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/10/16 00:14:16 UTC
[PR] [SPARK-45546][BUILD] Do not compile docs for snapshots deploy [spark]
LuciferYang opened a new pull request, #43378:
URL: https://github.com/apache/spark/pull/43378
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1769906566
Let's revert it for now in any event. Let me just directly revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Do not compile docs for snapshots deploy [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1359994898
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
Yes, you're correct. Even if it can be published successfully in the end, I think this is still a temporary solution. Since the final logs of the master's deploy task always stay at the doc build stage, I wonder if it would succeed by skipping this stage, also to provide some ideas for the next step of the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1363076367
##########
pom.xml:
##########
@@ -3847,4 +3847,11 @@
</build>
</profile>
</profiles>
+ <distributionManagement>
Review Comment:
Very sorry, I forgot to delete the code tested locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Skip compile docs for snapshots deploy [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361470246
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
👌
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1770077238
> Let's revert it for now in any event. Let me just directly revert
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Skip compile docs for snapshots deploy [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361468164
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
only when `GITHUB_ACTIONS` variable is set.
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
only when `GITHUB_ACTIONS` environment variable is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1769842267
It's a bit strange, I can still build successfully even after deleting the corresponding memory in `build_and_test`...
<img width="1669" alt="image" src="https://github.com/apache/spark/assets/1475305/44606fd2-b0ee-402d-a83b-f832635454fd">
https://github.com/LuciferYang/spark/actions/runs/6556632402/job/17807947667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361887966
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -66,4 +66,5 @@ jobs:
GPG_KEY: "not_used"
GPG_PASSPHRASE: "not_used"
GIT_REF: ${{ matrix.branch }}
+ PACKAGE_BEFORE_DEPLOY: true
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Skip compile docs for snapshots deploy [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361469975
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
lIke
```
$MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean package
$MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES deploy
```
?
Let me test it locally first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Skip compile docs for snapshots deploy [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361466539
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
Could we try this solution? I don't have a better idea at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1767504278
Merged into master. Let's try this. Thanks @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1363025158
##########
pom.xml:
##########
@@ -3847,4 +3847,11 @@
</build>
</profile>
</profiles>
+ <distributionManagement>
Review Comment:
Is this mistakenly added? made a pr to remove https://github.com/apache/spark/pull/43415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Do not compile docs for snapshots deploy [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1359989990
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
I considered this option .. but I think we should include them ideally. e.g., if you include SNAPSHOT, and your IDE won't show the relevant method documentation anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Skip compile docs for snapshots deploy [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361467998
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
Can we package first, and then run deploy?
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
running `mvn` twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1769905299
Hmmmmmmmm...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361879247
##########
.github/workflows/publish_snapshot.yml:
##########
@@ -66,4 +66,5 @@ jobs:
GPG_KEY: "not_used"
GPG_PASSPHRASE: "not_used"
GIT_REF: ${{ matrix.branch }}
+ PACKAGE_BEFORE_DEPLOY: true
Review Comment:
Let's add a comment here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361855312
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
Maven doesn't behave like SBT, it won't directly deploy the already packaged jars even after being split into two commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1766129230
> LGTM let's try
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361837955
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
The new code perform a two-step deployment (first package, then deploy) when `PACKAGE_BEFORE_DEPLOY` is true. However, after observing the compile log, I found that the second step's `scala:4.7.1:compile` and `scala:4.7.1:doc-jar` are not skipped. I'm unsure if this change can really solve the problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43378:
URL: https://github.com/apache/spark/pull/43378#discussion_r1361837955
##########
dev/create-release/release-build.sh:
##########
@@ -432,14 +432,14 @@ if [[ "$1" == "publish-snapshot" ]]; then
echo "</server></servers></settings>" >> $tmp_settings
if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -DskipTests -Dmaven.javadoc.skip=true $SCALA_2_12_PROFILES $PUBLISH_PROFILES clean deploy
fi
if [[ $PUBLISH_SCALA_2_13 = 1 ]]; then
if [[ $SPARK_VERSION < "4.0" ]]; then
./dev/change-scala-version.sh 2.13
fi
- $MVN --settings $tmp_settings -DskipTests $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
+ $MVN --settings $tmp_settings -DskipTests -Dmaven.javadoc.skip=true -Dmaven.scaladoc.skip=true $SCALA_2_13_PROFILES $PUBLISH_PROFILES clean deploy
Review Comment:
The new code perform a two-step deployment (first package, then deploy) when `PACKAGE_BEFORE_DEPLOY` is true. However, after observing the compile log, I found that the second step's `scala:4.7.1:compile`, and `scala:4.7.1:doc-jar` are not skipped. I'm unsure if this change can really solve the problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43378:
URL: https://github.com/apache/spark/pull/43378#issuecomment-1769812926
Unfortunately, it still failed.
https://github.com/apache/spark/actions/runs/6568013788/job/17841752529
`mvn package` was killed before it finished.
The difference between the `build_and_test` and `java-other-versions` tasks is that `java-other-versions` is configured to use less memory resources:
https://github.com/apache/spark/blob/8a972c2fe8730e41193986a273aa92b234e5beb8/.github/workflows/build_and_test.yml#L824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy` [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #43378: [SPARK-45546][BUILD][INFRA] Make `publish-snapshot` support `package` first then `deploy`
URL: https://github.com/apache/spark/pull/43378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org