You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Mirai1129 (via GitHub)" <gi...@apache.org> on 2025/06/04 11:13:59 UTC
[PR] MINOR: Safe update dependencies [kafka]
Mirai1129 opened a new pull request, #19897:
URL: https://github.com/apache/kafka/pull/19897
safely update Kafka dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #19897:
URL: https://github.com/apache/kafka/pull/19897#discussion_r2129008697
##########
gradle/dependencies.gradle:
##########
@@ -109,23 +109,23 @@ versions += [
mavenArtifact: "3.9.6",
metrics: "2.2.0",
mockito: "5.14.2",
- opentelemetryProto: "1.0.0-alpha",
+ opentelemetryProto: "1.3.2-alpha",
protobuf: "3.25.5", // a dependency of opentelemetryProto
- pcollections: "4.0.1",
- re2j: "1.7",
- rocksDB: "9.7.3",
+ pcollections: "4.0.2",
+ re2j: "1.8",
+ rocksDB: "9.7.4",
Review Comment:
I think we don’t need to update the RocksDB minor version in this PR, since another PR will handle the major version upgrade.
Ref: https://github.com/apache/kafka/pull/19880/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #19897:
URL: https://github.com/apache/kafka/pull/19897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19897:
URL: https://github.com/apache/kafka/pull/19897#issuecomment-2942960692
@Mirai1129 please update the license files too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on code in PR #19897:
URL: https://github.com/apache/kafka/pull/19897#discussion_r2129030196
##########
gradle/dependencies.gradle:
##########
@@ -53,33 +53,33 @@ versions += [
apacheda: "1.0.2",
apacheds: "2.0.0-M24",
argparse4j: "0.7.0",
- bcpkix: "1.78.1",
- caffeine: "3.1.8",
+ bcpkix: "1.80",
+ caffeine: "3.2.0",
bndlib: "7.0.0",
checkstyle: project.hasProperty('checkstyleVersion') ? checkstyleVersion : "10.20.2",
commonsValidator: "1.9.0",
- classgraph: "4.8.173",
+ classgraph: "4.8.179",
gradle: "8.14.1",
grgit: "4.1.1",
httpclient: "4.5.14",
jackson: "2.19.0",
- jacoco: "0.8.10",
+ jacoco: "0.8.13",
javassist: "3.29.2-GA",
- jetty: "12.0.15",
- jersey: "3.1.9",
+ jetty: "12.0.16",
+ jersey: "3.1.10",
jline: "3.25.1",
jmh: "1.37",
- hamcrest: "2.2",
+ hamcrest: "3.0",
scalaLogging: "3.9.5",
jaxAnnotation: "1.3.2",
jaxb: "2.3.1",
jakartaRs: "3.1.0",
jakartaServletApi: "6.1.0",
jfreechart: "1.0.0",
jopt: "5.0.4",
- jose4j: "0.9.4",
+ jose4j: "0.9.6",
junit: "5.10.2",
Review Comment:
```suggestion
junit: "5.13.0",
```
##########
gradle/dependencies.gradle:
##########
@@ -109,23 +109,23 @@ versions += [
mavenArtifact: "3.9.6",
metrics: "2.2.0",
mockito: "5.14.2",
Review Comment:
```suggestion
mockito: "5.18.0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19897:
URL: https://github.com/apache/kafka/pull/19897#discussion_r2132858137
##########
gradle/dependencies.gradle:
##########
@@ -108,25 +108,25 @@ versions += [
lz4: "1.8.0",
mavenArtifact: "3.9.6",
metrics: "2.2.0",
- mockito: "5.14.2",
- opentelemetryProto: "1.0.0-alpha",
+ mockito: "5.18.0",
+ opentelemetryProto: "1.7.0-alpha",
protobuf: "3.25.5", // a dependency of opentelemetryProto
- pcollections: "4.0.1",
- re2j: "1.7",
+ pcollections: "4.0.2",
+ re2j: "1.8",
rocksDB: "9.7.3",
// When updating the scalafmt version please also update the version field in checkstyle/.scalafmt.conf. scalafmt now
// has the version field as mandatory in its configuration, see
// https://github.com/scalameta/scalafmt/releases/tag/v3.1.0.
scalafmt: "3.7.14",
scoverage: "2.0.11",
slf4j: "1.7.36",
- snappy: "1.1.10.5",
+ snappy: "1.1.10.7",
spotbugs: "4.8.6",
zinc: "1.9.2",
// When updating the zstd version, please do as well in docker/native/native-image-configs/resource-config.json
// Also make sure the compression levels in org.apache.kafka.common.record.CompressionType are still valid
- zstd: "1.5.6-10",
- junitPlatform: "1.10.2",
+ zstd: "1.5.7-3",
+ junitPlatform: "1.13.0",
Review Comment:
please revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "Mirai1129 (via GitHub)" <gi...@apache.org>.
Mirai1129 commented on PR #19897:
URL: https://github.com/apache/kafka/pull/19897#issuecomment-2945393365
Thanks for the suggestion @m1a2st . I've updated the dependencies with safe version bumps in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19897:
URL: https://github.com/apache/kafka/pull/19897#discussion_r2134166912
##########
gradle/dependencies.gradle:
##########
@@ -108,19 +108,19 @@ versions += [
lz4: "1.8.0",
mavenArtifact: "3.9.6",
metrics: "2.2.0",
- mockito: "5.14.2",
- opentelemetryProto: "1.0.0-alpha",
+ mockito: "5.18.0",
+ opentelemetryProto: "1.7.0-alpha",
Review Comment:
this is not a small update. Could you please revert it to keep the update "safe"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies (wip) [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #19897:
URL: https://github.com/apache/kafka/pull/19897#issuecomment-2949391502
@Mirai1129 Please revert the update from junit-releated libraries. I have opened https://issues.apache.org/jira/browse/KAFKA-19382 to trace it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Safe update dependencies [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19897:
URL: https://github.com/apache/kafka/pull/19897#discussion_r2135715910
##########
gradle/dependencies.gradle:
##########
@@ -108,19 +108,19 @@ versions += [
lz4: "1.8.0",
mavenArtifact: "3.9.6",
metrics: "2.2.0",
- mockito: "5.14.2",
- opentelemetryProto: "1.0.0-alpha",
+ mockito: "5.18.0",
+ opentelemetryProto: "1.7.0-alpha",
Review Comment:
open https://issues.apache.org/jira/browse/KAFKA-19391 for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org