You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/06/30 10:14:54 UTC
[GitHub] zeppelin pull request #1109: [Zeppelin-1090] LivySparkSQLInterpreter doesn't...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1109
[Zeppelin-1090] LivySparkSQLInterpreter doesn't work in FIFO.
### What is this PR for?
LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
### What type of PR is it?
[Hot Fix]
### Todos
* [x] - LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
* [x] - add in property file zeppelin.livy.concurrentSQL
### What is the Jira issue?
* [Zeppelin-1090](https://issues.apache.org/jira/browse/ZEPPELIN-1090)
### How should this be tested?
In a notebook create 2 paragraph make content of first as
```
%livy
Thread.sleep(10000)
```
and other as
```
%livy.sql
show tables
```
The second paragraph should not get executed before first.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1090
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1109
----
commit 2f1c64c859413f8a43ceeeea345a0fa195ac940d
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-06-30T10:10:25Z
add in property file zeppelin.livy.concurrentSQL
commit fe2ec72ca103b6692234604fc020701e86bc6af1
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-06-30T10:10:39Z
LivySparkSQLInterpreter should work in FIFO just like SparkSqlInterpreter
commit a2f863ee4a27b1208d4e18ca8b85b1bce6a74a38
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2016-06-30T10:11:01Z
check for both dead and error cases
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1109: [Zeppelin-1090][Hot Fix] LivySparkSQLInterpreter doesn...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1109
Thanks for the fix. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1109: [Zeppelin-1090][Hot Fix] LivySparkSQLInterpreter doesn...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1109
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1109: [Zeppelin-1090] LivySparkSQLInterpreter doesn't work i...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1109
@bzz CI still fails https://github.com/apache/zeppelin/pull/1094
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.python.PythonInterpreterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.6.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
log4j:WARN No appenders could be found for logger (org.apache.zeppelin.interpreter.Interpreter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.424 sec <<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest) Time elapsed: 0.319 sec <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:141)
Results :
Failed tests:
PythonInterpreterTest.testClose:141 null
```
https://api.travis-ci.org/jobs/141302291/log.txt?deansi=true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1109: [Zeppelin-1090][Hot Fix] LivySparkSQLInterprete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---