You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/22 20:19:59 UTC
[jira] [Commented] (TWILL-128) Change the ZKBrokerService to be
public so it could be used outside the package
[ https://issues.apache.org/jira/browse/TWILL-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507589#comment-14507589 ]
ASF GitHub Bot commented on TWILL-128:
--------------------------------------
GitHub user hsaputra opened a pull request:
https://github.com/apache/incubator-twill/pull/31
TWILL-128 Change the ZKBrokerService to be public so it could be used outside the package.
Make ZKBrokerService to have public modifier so it could be used outside the package private.
The BrokerService interface that ZKBrokerService implemented is already public so it would be
helpful to make this implementation to be public so it could be used by external projects or code
when using Apache Kafka with Simple Customer APIs to resolve leader.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/incubator-twill TWILL-128_change_ZKBrokerService_to_be_public
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit a7878752b48002843392db35ecf26ebc2919372a
Author: hsaputra <hs...@apache.org>
Date: 2015-04-22T18:15:55Z
TWILL-128 Change the ZKBrokerService to be public so it could be used outside the package.
Make ZKBrokerService to have public modifier so it could be used outside the package private.
The BrokerService interface that ZKBrokerService implemented is already public so it would be
helpful to make this implementation to be public so it could be used by external projects or code
when using Apache Kafka with Simple Customer APIs to resolve leader.
----
> Change the ZKBrokerService to be public so it could be used outside the package
> -------------------------------------------------------------------------------
>
> Key: TWILL-128
> URL: https://issues.apache.org/jira/browse/TWILL-128
> Project: Apache Twill
> Issue Type: Improvement
> Components: core
> Reporter: Henry Saputra
> Priority: Minor
>
> Would like to make ZKBrokerService to have public modifier so it could be used outside the package private.
> The BrokerService interface that ZKBrokerService implement is already public so it would be helpful to make this implementation to be public so it could be used by external projects when trying to use Apache Kafka Simple Customer APIs to find the leader for example.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)