You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/20 10:30:03 UTC
[GitHub] [dubbo-go] fangyincheng opened a new pull request #945: fix bug
fangyincheng opened a new pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
fix generic "encode hessian.Object"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (f269e62) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
+ Coverage 60.03% 60.06% +0.02%
==========================================
Files 260 260
Lines 12855 12855
==========================================
+ Hits 7718 7721 +3
+ Misses 4174 4172 -2
+ Partials 963 962 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `38.98% <0.00%> (-0.85%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `53.68% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `81.52% <0.00%> (+2.17%)` | :arrow_up: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `70.63% <0.00%> (+3.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...3cf6ced](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (3cf6ced) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
- Coverage 60.03% 59.90% -0.14%
==========================================
Files 260 260
Lines 12855 12855
==========================================
- Hits 7718 7701 -17
- Misses 4174 4192 +18
+ Partials 963 962 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...3cf6ced](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (3cf6ced) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `0.13%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
- Coverage 60.03% 59.90% -0.14%
==========================================
Files 260 260
Lines 12855 12855
==========================================
- Hits 7718 7701 -17
- Misses 4174 4192 +18
+ Partials 963 962 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...c57982a](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (c57982a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
=======================================
Coverage 60.03% 60.04%
=======================================
Files 260 260
Lines 12855 12855
=======================================
+ Hits 7718 7719 +1
Misses 4174 4174
+ Partials 963 962 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `70.63% <0.00%> (+3.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...c57982a](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (3cf6ced) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `0.31%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
- Coverage 60.03% 59.71% -0.32%
==========================================
Files 260 260
Lines 12855 12855
==========================================
- Hits 7718 7677 -41
- Misses 4174 4214 +40
- Partials 963 964 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `52.17% <0.00%> (-8.70%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `64.31% <0.00%> (-5.29%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...3cf6ced](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (c57982a) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `0.12%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
- Coverage 60.03% 59.91% -0.13%
==========================================
Files 260 260
Lines 12855 12855
==========================================
- Hits 7718 7702 -16
- Misses 4174 4192 +18
+ Partials 963 961 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `70.63% <0.00%> (+3.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...c57982a](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (f269e62) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
- Coverage 60.03% 60.00% -0.04%
==========================================
Files 260 260
Lines 12855 12855
==========================================
- Hits 7718 7714 -4
- Misses 4174 4178 +4
Partials 963 963
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.90% <0.00%> (-2.41%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `38.98% <0.00%> (-0.85%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `70.63% <0.00%> (+3.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...f269e62](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #945: fix bug
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #945:
URL: https://github.com/apache/dubbo-go/pull/945#issuecomment-748590302
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=h1) Report
> Merging [#945](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=desc) (f269e62) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a347a0498e77be751b644010e566e636b0032d39?el=desc) (a347a04) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #945 +/- ##
==========================================
+ Coverage 60.03% 60.06% +0.02%
==========================================
Files 260 260
Lines 12855 12855
==========================================
+ Hits 7718 7721 +3
+ Misses 4174 4172 -2
+ Partials 963 962 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/router/healthcheck/default\_health\_check.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvaGVhbHRoY2hlY2svZGVmYXVsdF9oZWFsdGhfY2hlY2suZ28=) | `94.11% <ø> (ø)` | |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (ø)` | |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `38.98% <0.00%> (-0.85%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `53.68% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `81.52% <0.00%> (+2.17%)` | :arrow_up: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/945/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `70.63% <0.00%> (+3.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=footer). Last update [a347a04...f269e62](https://codecov.io/gh/apache/dubbo-go/pull/945?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org